Merge branch 'master' into integrations/cleanup

.bazeliskversion

@@ -1 +1 @@
-1.7.5
+1.10.1

.bazelrc

@@ -10,9 +10,6 @@ build --remote_timeout=30
 build --remote_header=x-buildbuddy-api-key=3EYk49W2NefOx2n3yMze
 build --remote_accept_cached=true
 
-# BuildBuddy
-## Metadata settings
-build --workspace_status_command="node ./src/dev/bazel_workspace_status.js"
 # Enable this in case you want to share your build info
 # build --build_metadata=VISIBILITY=PUBLIC
 build --build_metadata=TEST_GROUPS=//packages

.bazelrc.common

@@ -120,8 +120,8 @@ test --incompatible_strict_action_env
 # collect coverage information from test targets
 coverage --instrument_test_targets
 
-# Settings for CI
-# Bazel flags for CI are in /src/dev/ci_setup/.bazelrc-ci
+# Metadata settings
+build --workspace_status_command="node ./src/dev/bazel_workspace_status.js"
 
 # Load any settings specific to the current user.
 # .bazelrc.user should appear in .gitignore so that settings are not shared with team members

.bazelversion

@@ -1 +1 @@
-4.0.0
+4.2.1

.buildkite/pipelines/es_snapshots/verify.yml

@@ -13,6 +13,7 @@ steps:
 
   - command: .buildkite/scripts/lifecycle/pre_build.sh
     label: Pre-Build
+    timeout_in_minutes: 10
 
   - wait
 
@@ -22,6 +23,7 @@ steps:
       queue: c2-16
     key: build
     if: "build.env('KIBANA_BUILD_ID') == null || build.env('KIBANA_BUILD_ID') == ''"
+    timeout_in_minutes: 60
 
   - command: .buildkite/scripts/steps/functional/xpack_cigroup.sh
     label: 'Default CI Group'
@@ -81,6 +83,7 @@ steps:
 
   - command: .buildkite/scripts/steps/es_snapshots/trigger_promote.sh
     label: Trigger promotion
+    timeout_in_minutes: 10
     depends_on:
       - default-cigroup
       - default-cigroup-docker
@@ -93,3 +96,4 @@ steps:
 
   - command: .buildkite/scripts/lifecycle/post_build.sh
     label: Post-Build
+    timeout_in_minutes: 10

.buildkite/pipelines/hourly.yml

@@ -3,6 +3,7 @@ env:
 steps:
   - command: .buildkite/scripts/lifecycle/pre_build.sh
     label: Pre-Build
+    timeout_in_minutes: 10
 
   - wait
 
@@ -12,6 +13,7 @@ steps:
       queue: c2-16
     key: build
     if: "build.env('KIBANA_BUILD_ID') == null || build.env('KIBANA_BUILD_ID') == ''"
+    timeout_in_minutes: 60
 
   - command: .buildkite/scripts/steps/functional/xpack_cigroup.sh
     label: 'Default CI Group'
@@ -143,21 +145,25 @@ steps:
     agents:
       queue: n2-2
     key: linting
+    timeout_in_minutes: 90
 
   - command: .buildkite/scripts/steps/checks.sh
     label: 'Checks'
     agents:
       queue: c2-4
     key: checks
+    timeout_in_minutes: 120
 
   - command: .buildkite/scripts/steps/storybooks/build_and_upload.sh
     label: 'Build Storybooks'
     agents:
       queue: c2-4
     key: storybooks
+    timeout_in_minutes: 60
 
   - wait: ~
     continue_on_failure: true
 
   - command: .buildkite/scripts/lifecycle/post_build.sh
     label: Post-Build
+    timeout_in_minutes: 10

.buildkite/pipelines/on_merge.yml

@@ -4,21 +4,27 @@ env:
 steps:
   - command: .buildkite/scripts/lifecycle/pre_build.sh
     label: Pre-Build
+    timeout_in_minutes: 10
 
   - wait
 
   - command: .buildkite/scripts/steps/on_merge_build_and_metrics.sh
     label: Default Build and Metrics
+    env:
+      BAZEL_CACHE_MODE: read-write
     agents:
       queue: c2-8
+    timeout_in_minutes: 60
 
   - command: .buildkite/scripts/steps/on_merge_ts_refs_api_docs.sh
     label: Build TS Refs and Check Public API Docs
     agents:
       queue: c2-4
+    timeout_in_minutes: 80
 
   - wait: ~
     continue_on_failure: true
 
   - command: .buildkite/scripts/lifecycle/post_build.sh
     label: Post-Build
+    timeout_in_minutes: 10

.buildkite/pipelines/pull_request/base.yml

@@ -1,6 +1,7 @@
 steps:
   - command: .buildkite/scripts/lifecycle/pre_build.sh
     label: Pre-Build
+    timeout_in_minutes: 10
 
   - wait
 
@@ -10,14 +11,15 @@ steps:
       queue: c2-16
     key: build
     if: "build.env('KIBANA_BUILD_ID') == null || build.env('KIBANA_BUILD_ID') == ''"
+    timeout_in_minutes: 60
 
   - command: .buildkite/scripts/steps/functional/xpack_cigroup.sh
     label: 'Default CI Group'
     parallelism: 13
     agents:
       queue: ci-group-6
     depends_on: build
-    timeout_in_minutes: 120
+    timeout_in_minutes: 150
     key: default-cigroup
     retry:
       automatic:
@@ -141,15 +143,18 @@ steps:
     agents:
       queue: n2-2
     key: linting
+    timeout_in_minutes: 90
 
   - command: .buildkite/scripts/steps/checks.sh
     label: 'Checks'
     agents:
       queue: c2-4
     key: checks
+    timeout_in_minutes: 120
 
   - command: .buildkite/scripts/steps/storybooks/build_and_upload.sh
     label: 'Build Storybooks'
     agents:
       queue: c2-4
     key: storybooks
+    timeout_in_minutes: 60

.buildkite/pipelines/update_demo_env.yml

@@ -1,8 +1,10 @@
 steps:
   - command: .buildkite/scripts/steps/demo_env/es_and_init.sh
     label: Initialize Environment and Deploy ES
+    timeout_in_minutes: 10
 
   - command: .buildkite/scripts/steps/demo_env/kibana.sh
     label: Build and Deploy Kibana
     agents:
       queue: c2-8
+    timeout_in_minutes: 60

.buildkite/scripts/bootstrap.sh

@@ -3,6 +3,7 @@
 set -euo pipefail
 
 source .buildkite/scripts/common/util.sh
+source .buildkite/scripts/common/setup_bazel.sh
 
 echo "--- yarn install and bootstrap"
 retry 2 15 yarn kbn bootstrap

.buildkite/scripts/common/setup_bazel.sh

@@ -0,0 +1,38 @@
+#!/usr/bin/env bash
+
+source .buildkite/scripts/common/util.sh
+
+KIBANA_BUILDBUDDY_CI_API_KEY=$(retry 5 5 vault read -field=value secret/kibana-issues/dev/kibana-buildbuddy-ci-api-key)
+export KIBANA_BUILDBUDDY_CI_API_KEY
+
+echo "[bazel] writing .bazelrc"
+cat <<EOF > $KIBANA_DIR/.bazelrc
+  # Generated by .buildkite/scripts/common/setup_bazel.sh
+
+  import %workspace%/.bazelrc.common
+
+  build --build_metadata=ROLE=CI
+EOF
+
+if [[ "${BAZEL_CACHE_MODE:-none}" == read* ]]; then
+  echo "[bazel] enabling caching"
+cat <<EOF >> $KIBANA_DIR/.bazelrc
+  build --bes_results_url=https://app.buildbuddy.io/invocation/
+  build --bes_backend=grpcs://cloud.buildbuddy.io
+  build --remote_cache=grpcs://cloud.buildbuddy.io
+  build --remote_timeout=3600
+  build --remote_header=x-buildbuddy-api-key=$KIBANA_BUILDBUDDY_CI_API_KEY
+EOF
+fi
+
+if [[ "${BAZEL_CACHE_MODE:-none}" == "read" ]]; then
+  echo "[bazel] cache set to read-only"
+cat <<EOF >> $KIBANA_DIR/.bazelrc
+  build --noremote_upload_local_results
+EOF
+fi
+
+if [[ "${BAZEL_CACHE_MODE:-none}" != @(read|read-write|none|) ]]; then
+  echo "invalid value for BAZEL_CACHE_MODE received ($BAZEL_CACHE_MODE), expected one of [read,read-write,none]"
+  exit 1
+fi

.buildkite/scripts/common/util.sh

@@ -18,7 +18,7 @@ verify_no_git_changes() {
   RED='\033[0;31m'
   C_RESET='\033[0m' # Reset color
 
-  GIT_CHANGES="$(git ls-files --modified)"
+  GIT_CHANGES="$(git ls-files --modified -- . ':!:.bazelrc')"
   if [ "$GIT_CHANGES" ]; then
     echo -e "\n${RED}ERROR: '$1' caused changes to the following files:${C_RESET}\n"
     echo -e "$GIT_CHANGES\n"

.buildkite/scripts/steps/on_merge_build_and_metrics.sh

@@ -2,9 +2,6 @@
 
 set -euo pipefail
 
-# Write Bazel cache for Linux
-.buildkite/scripts/common/persist_bazel_cache.sh
-
 .buildkite/scripts/bootstrap.sh
 .buildkite/scripts/build_kibana.sh
 .buildkite/scripts/post_build_kibana.sh

WORKSPACE.bazel

@@ -28,6 +28,7 @@ check_rules_nodejs_version(minimum_version_string = "3.8.0")
 node_repositories(
   node_repositories = {
     "16.11.1-darwin_amd64": ("node-v16.11.1-darwin-x64.tar.gz", "node-v16.11.1-darwin-x64", "ba54b8ed504bd934d03eb860fefe991419b4209824280d4274f6a911588b5e45"),
+    "16.11.1-darwin_arm64": ("node-v16.11.1-darwin-arm64.tar.gz", "node-v16.11.1-darwin-arm64", "5e772e478390fab3001b7148a923e4f22fca50170000f18b28475337d3a97248"),
     "16.11.1-linux_arm64": ("node-v16.11.1-linux-arm64.tar.xz", "node-v16.11.1-linux-arm64", "083fc51f0ea26de9041aaf9821874651a9fd3b20d1cf57071ce6b523a0436f17"),
     "16.11.1-linux_s390x": ("node-v16.11.1-linux-s390x.tar.xz", "node-v16.11.1-linux-s390x", "855b5c83c2ccb05273d50bb04376335c68d47df57f3187cdebe1f22b972d2825"),
     "16.11.1-linux_amd64": ("node-v16.11.1-linux-x64.tar.xz", "node-v16.11.1-linux-x64", "493bcc9b660eff983a6de65a0f032eb2717f57207edf74c745bcb86e360310b3"),

src/dev/build/lib/config.test.ts

@@ -107,6 +107,7 @@ describe('#getTargetPlatforms()', () => {
         .sort()
     ).toMatchInlineSnapshot(`
       Array [
+        "darwin-arm64",
         "darwin-x64",
         "linux-arm64",
         "linux-x64",
@@ -132,7 +133,7 @@ describe('#getNodePlatforms()', () => {
         .getTargetPlatforms()
         .map((p) => p.getNodeArch())
         .sort()
-    ).toEqual(['darwin-x64', 'linux-arm64', 'linux-x64', 'win32-x64']);
+    ).toEqual(['darwin-arm64', 'darwin-x64', 'linux-arm64', 'linux-x64', 'win32-x64']);
   });
 
   it('returns this platform and linux, when targetAllPlatforms = false', async () => {

src/dev/build/lib/platform.test.ts

@@ -31,6 +31,7 @@ describe('isWindows()', () => {
     expect(new Platform('win32', 'x64', 'foo').isWindows()).toBe(true);
     expect(new Platform('linux', 'x64', 'foo').isWindows()).toBe(false);
     expect(new Platform('darwin', 'x64', 'foo').isWindows()).toBe(false);
+    expect(new Platform('darwin', 'arm64', 'foo').isWindows()).toBe(false);
   });
 });
 
@@ -39,6 +40,7 @@ describe('isLinux()', () => {
     expect(new Platform('win32', 'x64', 'foo').isLinux()).toBe(false);
     expect(new Platform('linux', 'x64', 'foo').isLinux()).toBe(true);
     expect(new Platform('darwin', 'x64', 'foo').isLinux()).toBe(false);
+    expect(new Platform('darwin', 'arm64', 'foo').isLinux()).toBe(false);
   });
 });
 
@@ -47,5 +49,6 @@ describe('isMac()', () => {
     expect(new Platform('win32', 'x64', 'foo').isMac()).toBe(false);
     expect(new Platform('linux', 'x64', 'foo').isMac()).toBe(false);
     expect(new Platform('darwin', 'x64', 'foo').isMac()).toBe(true);
+    expect(new Platform('darwin', 'arm64', 'foo').isMac()).toBe(true);
   });
 });

src/dev/build/lib/platform.ts

@@ -49,5 +49,6 @@ export const ALL_PLATFORMS = [
   new Platform('linux', 'x64', 'linux-x86_64'),
   new Platform('linux', 'arm64', 'linux-aarch64'),
   new Platform('darwin', 'x64', 'darwin-x86_64'),
+  new Platform('darwin', 'arm64', 'darwin-aarch64'),
   new Platform('win32', 'x64', 'windows-x86_64'),
 ];

src/dev/build/tasks/install_chromium.js

@@ -16,7 +16,11 @@ export const InstallChromium = {
 
   async run(config, log, build) {
     for (const platform of config.getNodePlatforms()) {
-      log.info(`Installing Chromium for ${platform.getName()}-${platform.getArchitecture()}`);
+      const target = `${platform.getName()}-${platform.getArchitecture()}`;
+      log.info(`Installing Chromium for ${target}`);
+
+      // revert after https://github.com/elastic/kibana/issues/109949
+      if (target === 'darwin-arm64') continue;
 
       const { binaryPath$ } = installBrowser(
         log,

src/dev/build/tasks/nodejs/download_node_builds_task.test.ts

@@ -98,6 +98,15 @@ it('downloads node builds for each platform', async () => {
           "url": "darwin:url",
         },
       ],
+      Array [
+        Object {
+          "destination": "darwin:downloadPath",
+          "log": <ToolingLog>,
+          "retries": 3,
+          "sha256": "darwin:sha256",
+          "url": "darwin:url",
+        },
+      ],
       Array [
         Object {
           "destination": "win32:downloadPath",

src/dev/build/tasks/nodejs/extract_node_builds_task.test.ts

@@ -105,6 +105,13 @@ it('runs expected fs operations', async () => {
             "strip": 1,
           },
         ],
+        Array [
+          <absolute path>/.node_binaries/<node version>/node-v<node version>-darwin-arm64.tar.gz,
+          <absolute path>/.node_binaries/<node version>/darwin-arm64,
+          Object {
+            "strip": 1,
+          },
+        ],
       ],
     }
   `);