Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add contributor agreement prereq to dev docs #3904

Merged
merged 2 commits into from
Aug 16, 2022
Merged

[docs] Add contributor agreement prereq to dev docs #3904

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73fcc63
Add contributor agreement prereq to dev docs
Jul 29, 2022
4902d85
Update docs/developer_workflow_design_build_test_integration.md
mdavis332 Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/developer_workflow_design_build_test_integration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ using the tool's [documentation](https://github.com/elastic/elastic-package/tree

### Open a PR

If you think that you've finished works on your integration, you've verified that it collects data, wrote some tests,
Prior to opening a PR, you must sign the [elastic contributor agreement](https://www.elastic.co/contributor-agreement) if you haven't already. CI builds will fail if this agreement isn't on file for your GitHub username.
mdavis332 marked this conversation as resolved.
Show resolved Hide resolved

If you think that you've finished work on your integration, you've verified that it collects data, and you've written some tests,
you can [open a PR](https://github.com/elastic/integrations/compare) to include your integration in the [Integrations](https://github.com/elastic/integrations) repository.
The CI will verify if your integration is correct (`elastic-package check`) - a green status is a must.

Expand Down