Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add contributor agreement prereq to dev docs #3904

Merged
merged 2 commits into from
Aug 16, 2022
Merged

[docs] Add contributor agreement prereq to dev docs #3904

merged 2 commits into from
Aug 16, 2022

Conversation

mdavis332
Copy link
Contributor

What does this PR do?

CI builds fail if the elastic contributor agreement isn't on file for a github user. However, I didn't see that info anywhere prior to trying to submit my first integration so my initial CI build failed due to it.

This PR adds that language to the dev docs about building a new integration, specifically in the Open a PR section.

Related issues

@mdavis332 mdavis332 requested a review from a team as a code owner July 29, 2022 13:52
@cla-checker-service
Copy link

cla-checker-service bot commented Jul 29, 2022

💚 CLA has been signed

@elasticmachine
Copy link

elasticmachine commented Jul 29, 2022

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-16T08:16:14.734+0000

  • Duration: 110 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 5154
Skipped 9
Total 5163

Steps errors 4

Expand to view the steps failures

Test integration: containerd
  • Took 1 min 51 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Test integration: docker
  • Took 1 min 26 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Test integration: fireeye
  • Took 2 min 58 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Delete kind cluster
  • Took 0 min 13 sec . View more details here
  • Description: kind delete cluster

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mdavis332
Copy link
Contributor Author

i signed the contributor agreement a few days ago shortly after my CI check for #3839 failed. just a heads up for any elastic team member looking at this, perhaps there's some manual work needed once the agreement is submitted before it registers with the CI pipeline? i.e., I would have expected the CLA check to not fail today since I signed it several days ago.

@jsoriano
Copy link
Member

Hey @mdavis332, looking to the information about you in the CLA checker, it looks like you signed the CLA with a different email address than the one used in this commit. You need to sign the CLA with the same email address that you use in your commits.

You can find here the raw patch for the commit of this PR, where your email appears: https://github.com/elastic/integrations/commit/73fcc63fe3c9a7ef5f233833368df7d7ab6f7a78.patch

Could you try to modify your commit to use the same email address you used to sign the CLA? Or sign the CLA with the email you are using in your commits?

@mdavis332
Copy link
Contributor Author

Hi @jsoriano, thank you for the help pointing that out! Git still routinely confounds me and I (mistakenly) intuited that the cla-checker-service would use the github username supplied in the contributor agreement rather than the user.email in the git config.

As my git-foo is such that it would take me longer to figure out how to fix that commit, I just re-signed the agreement with the email addr set in that config. Will that work?

@jsoriano
Copy link
Member

jsoriano commented Aug 1, 2022

Will that work?

CLA checker seems happy now, so it seems it worked :) thanks!

@jsoriano
Copy link
Member

jsoriano commented Aug 1, 2022

/test

@elasticmachine
Copy link

elasticmachine commented Aug 1, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (282/282) 💚
Files 97.143% (510/525) 👍 0.022
Classes 97.143% (510/525) 👍 0.022
Methods 89.175% (4910/5506) 👎 -0.883
Lines 90.919% (92580/101827) 👎 -0.908
Conditionals 100.0% (0/0) 💚

@jsoriano
Copy link
Member

/test

@jsoriano jsoriano merged commit d07b80f into elastic:main Aug 16, 2022
@mdavis332 mdavis332 mentioned this pull request Aug 23, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants