-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add contributor agreement prereq to dev docs #3904
[docs] Add contributor agreement prereq to dev docs #3904
Conversation
💚 CLA has been signed |
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
i signed the contributor agreement a few days ago shortly after my CI check for #3839 failed. just a heads up for any elastic team member looking at this, perhaps there's some manual work needed once the agreement is submitted before it registers with the CI pipeline? i.e., I would have expected the CLA check to not fail today since I signed it several days ago. |
Hey @mdavis332, looking to the information about you in the CLA checker, it looks like you signed the CLA with a different email address than the one used in this commit. You need to sign the CLA with the same email address that you use in your commits. You can find here the raw patch for the commit of this PR, where your email appears: https://github.com/elastic/integrations/commit/73fcc63fe3c9a7ef5f233833368df7d7ab6f7a78.patch Could you try to modify your commit to use the same email address you used to sign the CLA? Or sign the CLA with the email you are using in your commits? |
Hi @jsoriano, thank you for the help pointing that out! Git still routinely confounds me and I (mistakenly) intuited that the cla-checker-service would use the github username supplied in the contributor agreement rather than the As my git-foo is such that it would take me longer to figure out how to fix that commit, I just re-signed the agreement with the email addr set in that config. Will that work? |
CLA checker seems happy now, so it seems it worked :) thanks! |
/test |
🌐 Coverage report
|
Co-authored-by: Jaime Soriano Pastor <[email protected]>
/test |
What does this PR do?
CI builds fail if the elastic contributor agreement isn't on file for a github user. However, I didn't see that info anywhere prior to trying to submit my first integration so my initial CI build failed due to it.
This PR adds that language to the dev docs about building a new integration, specifically in the Open a PR section.
Related issues