Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCP] Convert GCP Compute metricset from lightweight #3797

Merged
merged 5 commits into from
Sep 15, 2022
Merged

[GCP] Convert GCP Compute metricset from lightweight #3797

merged 5 commits into from
Sep 15, 2022

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Convert GCP Compute metricset from lightweight

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested review from a team as code owners July 21, 2022 18:02
@legoguy1000 legoguy1000 mentioned this pull request Jul 21, 2022
Closed
4 tasks
@elasticmachine
Copy link

elasticmachine commented Jul 21, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-14T20:59:03.533+0000

  • Duration: 17 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 82
Skipped 0
Total 82

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@r00tu53r
Copy link
Contributor

/test

@elasticmachine
Copy link

elasticmachine commented Jul 22, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 2.693
Classes 100.0% (5/5) 💚 2.693
Methods 90.816% (89/98) 👍 1.118
Lines 95.752% (1375/1436) 👍 4.348
Conditionals 100.0% (0/0) 💚

@endorama endorama added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Aug 1, 2022
@legoguy1000
Copy link
Contributor Author

@endorama can we merge this?

@legoguy1000
Copy link
Contributor Author

@endorama Is this able to be merged?

@legoguy1000
Copy link
Contributor Author

@kaiyan-sheng Can u review?

@kaiyan-sheng
Copy link
Contributor

/test

@kaiyan-sheng kaiyan-sheng merged commit d80b84f into elastic:main Sep 15, 2022
@andrewkroh andrewkroh mentioned this pull request Sep 19, 2022
Merged
@legoguy1000 legoguy1000 deleted the 3721-gcp-compute-lightweight branch September 20, 2022 05:44
@endorama endorama mentioned this pull request Sep 29, 2022
Closed
@andrewkroh andrewkroh mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r00tu53r r00tu53r r00tu53r approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees
No one assigned
Labels
Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GCP] Remove lightweight module in gcp.compute data stream
5 participants
@legoguy1000 @elasticmachine @r00tu53r @kaiyan-sheng @endorama