Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp.compute data stream does not collect data in correct namespace #4342

Closed
endorama opened this issue Sep 29, 2022 · 7 comments · Fixed by #4343 or #4374
Closed

gcp.compute data stream does not collect data in correct namespace #4342

endorama opened this issue Sep 29, 2022 · 7 comments · Fixed by #4343 or #4374
Assignees
Labels
bug Something isn't working, use only for issues

Comments

@endorama
Copy link
Member

endorama commented Sep 29, 2022

As per #3188 we started removing usage of Beats lightweight modules from gcp package data streams.

To remove them, we are directly using the gcp.metrics Metribeat module.

Today we uncovered an issue with he migration: data are collected all under gcp.metrics namespace, instead of gcp.<data stream name> namespace.

The first version with the issue is 2.11.0 (#3797)

Affected versions:

  • 2.11.0
  • 2.11.1
  • 2.11.2 (not yet promoted to production)
  • 2.11.3 (not yet promoted to production)
  • 2.11.4 (not yet promoted to production)
  • 2.11.5 (not yet promoted to production)
  • 2.11.6 (not yet promoted to production)
  • 2.11.7 (not yet promoted to production)
  • 2.11.8 (not yet promoted to production)

Affected data streams:

  • gcp.compute in 2.11.0
  • gcp.firestore in 2.11.2 (not yet promoted to production)
  • gcp.storage in 2.11.5 (not yet promoted to production)
  • gcp.pubsub in 2.11.4 (not yet promoted to production)
  • gcp.loadbalancing in 2.11.6 (not yet promoted to production)
  • gcp.dataproc in 2.11.7 (not yet promoted to production)

Fixes released in:

@endorama endorama added the bug Something isn't working, use only for issues label Sep 29, 2022
@endorama endorama changed the title gcp.compute data stream does not collect data gcp.compute data stream does not collect data in correct namespace Sep 29, 2022
@legoguy1000
Copy link
Contributor

That's my bad, I was tracking that this, https://github.com/elastic/beats/blob/main/x-pack/metricbeat/module/gcp/metrics/response_parser.go#L82, was doing all the renaming but I guess I missed the parent field renaming being done by the module

@endorama
Copy link
Member Author

No worries, we missed it too. I think we missed because is not part of the metricset but is being done somewhere in libbeat.

If you could update any open PR (if there are any still open) with this change that would be appreciated.

@endorama
Copy link
Member Author

While working on fixing this we also discovered an issue affecting (probably) the entire gcp package due to a invalid YAML indentation that Kibana UI complained when adding a new integration. Already fixed with #4355

@endorama
Copy link
Member Author

Reopening as this relates to multiple PRs

@endorama
Copy link
Member Author

endorama commented Oct 4, 2022

All PRs have been merged. I'll release gcp 2.11.10 with all the fixes.

@endorama
Copy link
Member Author

endorama commented Oct 4, 2022

This is being released in elastic/package-storage#5786

@endorama
Copy link
Member Author

endorama commented Oct 5, 2022

We missed the ingest pipeline for gke as was not included in the listed PRs #4357

Fixes released as part of 2.11.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues
Projects
None yet
3 participants