Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency on elastic-package #307

Merged
merged 5 commits into from
Oct 14, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Oct 13, 2020

@mtojek mtojek self-assigned this Oct 13, 2020
@elasticmachine
Copy link

elasticmachine commented Oct 13, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #307 updated]

  • Start Time: 2020-10-14T13:06:44.511+0000

  • Duration: 10 min 29 sec

@mtojek
Copy link
Contributor Author

mtojek commented Oct 13, 2020

CI failed, because it couldn't determine the default was present, but set to empty array. Actually all these fields are not required, so we can remove them.

@mtojek mtojek requested a review from ycombinator October 13, 2020 11:21
@andresrc andresrc added the Team:Integrations Label for the Integrations team label Oct 13, 2020
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@mtojek mtojek requested a review from ycombinator October 14, 2020 13:10
@mtojek mtojek requested a review from ycombinator October 14, 2020 14:05
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mtojek mtojek merged commit 5da20cb into elastic:master Oct 14, 2020
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* Update dependency on elastic-package

* Fix: redundant empty list

* Fix: docker image for Apache

* Revert "Fix: redundant empty list"

This reverts commit b75f97c.

* Fix: make check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manifest files: add support for corresponding flat and object properties
4 participants