Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest files: add support for corresponding flat and object properties #55

Closed
mtojek opened this issue Sep 30, 2020 · 4 comments · Fixed by elastic/integrations#307
Closed
Assignees

Comments

@mtojek
Copy link
Contributor

mtojek commented Sep 30, 2020

Due to different implementations, some properties may be considered as faulty:

kibana.version: 1

vs.

kibana:
   version: 1

Same for: elasticsearch.index_template.mappings

The goal of this task is to research all places that are required to be adjusted in elastic-package and in package-spec.

@ycombinator
Copy link
Contributor

I haven’t dug into this but it seems like something we should fix in the package spec go library? If so, should we move this issue to that repo?

@mtojek
Copy link
Contributor Author

mtojek commented Sep 30, 2020

I'm not quite sure how is this handled by elastic-package, but if it depends on standard json.Marshal/Unmarshal, then probably it needs an adjustment too.

@mtojek mtojek self-assigned this Oct 6, 2020
@mtojek
Copy link
Contributor Author

mtojek commented Oct 6, 2020

I researched the area a bit and it looks that the only place to be affected in the elastic-package is this place:
https://github.com/elastic/elastic-package/blob/master/internal/packages/packages.go#L90

I will focus on the package-spec first and transform the issue there as you suggested.

@mtojek mtojek transferred this issue from elastic/elastic-package Oct 6, 2020
@mtojek
Copy link
Contributor Author

mtojek commented Oct 7, 2020

As the change is merged to package-spec I will adjust the elastic-package to support flat/object properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants