Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go dependencies #1270

Merged
merged 8 commits into from
Apr 4, 2022
Merged

Update Go dependencies #1270

merged 8 commits into from
Apr 4, 2022

Conversation

ph
Copy link
Contributor

@ph ph commented Mar 29, 2022

What is the problem this PR solves?

Some of the indirect dependencies are required to be updated.

  • Update beats to latest master and the indirect dependencies
  • Move from jwt-go golang-jwt/jwt (new maintained version)
  • add overrides for goe
  • add CC0 to list of accepted license.

How to test this PR locally

Checklist

- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files
- [ ] I have added tests that prove my fix is effective or that my feature works
-[x] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@ph ph added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Mar 29, 2022
@ph ph self-assigned this Mar 29, 2022
@ph ph requested a review from a team as a code owner March 29, 2022 20:17
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2022

This pull request does not have a backport label. Could you fix it @ph? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v/d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Mar 29, 2022
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 29, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-01T20:41:36.148+0000

  • Duration: 10 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 271
Skipped 0
Total 271

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ph
Copy link
Contributor Author

ph commented Mar 29, 2022

This will require more works, see elastic/beats#28716 for some of the pain.

go.mod Outdated Show resolved Hide resolved
ph added 7 commits April 1, 2022 15:48
Some of the `indirect` dependencies required to be updated.

- Update beats to latest master and the indirect dependencies
- Update containerd 2.8.1
- Update distribution to 1.5.1
- Move from jwt-go golang-jwt/jwt (new maintained version)
This add the required overrides and rules for the CC0,
The CC0 is in our green light list.

Notes: This is an indirect dependencies coming from beats, this is
present in both beats and apm-server. Both of theses project doesn't
have rules or overrides in place to allow it. I've lost time to investigate why
the license detector didn't raise any issue in their repository.

Looking at both projects `go.sum` the dependencies is defined.
If you run `go list -m all` you will see it. The output of this command
result is used by our `go-licence-detector` to flag incompatible license.
@ph ph added backport-v8.3.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Apr 4, 2022
@ph ph requested a review from a team April 4, 2022 11:46
ph added a commit to ph/fleet-server that referenced this pull request Apr 4, 2022
We have seems weirds behavior in Darwin and Windows execution of the
linting. Until all the errors are fixes this is a bit counter productive
to run it on everything. It will just multiply the errors detected.

Ref: elastic#1270
@ph ph requested a review from jlind23 April 4, 2022 15:31
mergify bot pushed a commit that referenced this pull request Apr 4, 2022
We have seems weirds behavior in Darwin and Windows execution of the
linting. Until all the errors are fixes this is a bit counter productive
to run it on everything. It will just multiply the errors detected.

Ref: #1270
(cherry picked from commit 23b98b2)
@ph ph added backport-v8.2.0 Automated backport with mergify and removed backport-v8.2.0 Automated backport with mergify labels Apr 4, 2022
@ph ph merged commit a84fefe into elastic:main Apr 4, 2022
mergify bot added a commit that referenced this pull request Apr 6, 2022
* Update Go dependencies

Some of the `indirect` dependencies required to be updated.

- Update beats to latest master and the indirect dependencies
- Update containerd 2.8.1
- Update distribution to 1.5.1
- Move from jwt-go golang-jwt/jwt (new maintained version)

(cherry picked from commit ba22241)

* update beats

(cherry picked from commit ac5cfe5)

* Depends on elastic/elastic-agent modules

(cherry picked from commit 1962755)

* updating beats

(cherry picked from commit 7eac829)

* Dependencies tidy

(cherry picked from commit d1cfa99)

* add overrides for e2e-testing

(cherry picked from commit ea589c8)

* Correctly fix the `goe` dependency

This add the required overrides and rules for the CC0,
The CC0 is in our green light list.

Notes: This is an indirect dependencies coming from beats, this is
present in both beats and apm-server. Both of theses project doesn't
have rules or overrides in place to allow it. I've lost time to investigate why
the license detector didn't raise any issue in their repository.

Looking at both projects `go.sum` the dependencies is defined.
If you run `go list -m all` you will see it. The output of this command
result is used by our `go-licence-detector` to flag incompatible license.

(cherry picked from commit 3aa593e)

* Update server.New method signature

(cherry picked from commit 9d4f2e9)

Co-authored-by: Pier-Hugues Pellerin <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.2.0 Automated backport with mergify backport-v8.3.0 Automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants