Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird behavior in beats go-licence-detector for github.com/pascaldekloe/goe #31112

Closed
ph opened this issue Apr 1, 2022 · 4 comments
Closed
Labels
Stalled Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@ph
Copy link
Contributor

ph commented Apr 1, 2022

I run into a weird issue when upgrading fleet-server to the latest version of beats in elastic/fleet-server#1270

When the detector complained about not finding the license for the github.com/pascaldekloe/goe
I've added an overrides in fleet-server since the license is compatible (CC0) with our policy.

This is an indirect dependency coming from beats. This dependency is
present in both beats and apm-server. Both of theses project doesn't
have rules or overrides in place to allow it. I've lost time to investigate why
the license detector didn't raise any issue in the beats repository and
I still don't know why.

Looking at both projects go.sum the dependency is defined.
If you run go list -m all you will see it. The output of the command is pipe to
go-licence-detector .

@ph ph added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Apr 1, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@ph ph changed the title Weird behavior in beats go-license-detector for github.com/pascaldekloe/goe Weird behavior in beats go-licence-detector for github.com/pascaldekloe/goe Apr 1, 2022
@cmacknz
Copy link
Member

cmacknz commented Apr 4, 2022

What action do you want us to take with this one @ph?

@ph
Copy link
Contributor Author

ph commented Apr 5, 2022

@cmacknz Anyone in your team seen this or not? I am curious why you don't have any overrides in place for the license?
I don't understand exactly why your repository doesn't have that problem.

@botelastic
Copy link

botelastic bot commented Apr 5, 2023

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Apr 5, 2023
@botelastic botelastic bot closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stalled Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

No branches or pull requests

3 participants