Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiEmptyPrompt] Removed min-height for vertical layouts #5763

Merged
merged 5 commits into from
Apr 12, 2022

Conversation

elizabetdev
Copy link
Contributor

@elizabetdev elizabetdev commented Apr 6, 2022

Summary

Fixes #5755.

This PR fixes a bug in EuiEmptyPrompt where a min-height was unnecessary being applied for vertical layouts.

empty-prompt-min-height-issue@2x

Checklist

  • Checked in both light and dark modes
  • [ ] Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs and playground toggles
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for any docs examples
  • [ ] Added or updated jest and cypress tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • [ ] Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@elizabetdev elizabetdev marked this pull request as draft April 6, 2022 13:33
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5763/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5763/

@elizabetdev elizabetdev changed the title [EuiEmptyPrompt] Removed min-height for vertical layouts [EuiEmptyPrompt] Removed min-height for vertical layouts Apr 7, 2022
@elizabetdev elizabetdev marked this pull request as ready for review April 7, 2022 14:05
@cchaos cchaos self-requested a review April 11, 2022 15:27
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Fixed! Thank you.

upcoming_changelogs/5763.md Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5763/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5763/

@elizabetdev elizabetdev merged commit 91f0b73 into elastic:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiEmptyPrompt] Is too tall with no easy way to customize
3 participants