Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiEmptyPrompt] Is too tall with no easy way to customize #5755

Closed
cchaos opened this issue Apr 1, 2022 · 1 comment · Fixed by #5763
Closed

[EuiEmptyPrompt] Is too tall with no easy way to customize #5755

cchaos opened this issue Apr 1, 2022 · 1 comment · Fixed by #5763
Assignees
Labels

Comments

@cchaos
Copy link
Contributor

cchaos commented Apr 1, 2022

When the new layouts were introduced the styles were optimized for instances that had lots of content. However for simple prompts like errors or "no results", the min-height is too tall and is a bit awkward. I've run into it myself, but I've also seen others hack their way on top of it: elastic/kibana#128925 (review)

Example of being able to not have anything but a title:
Screen Shot 2022-04-01 at 16 22 00 PM

@elizabetdev
Copy link
Contributor

I can remove the min-height, it was a stupid idea to add it. 😬

The purpose was to make the empty/loading/error experience look better but I guess it is better if consumers add their own min-height for these scenarios.

Screen.Recording.2022-04-04.at.01.10.06.PM.mp4

So I'll remove the min-height from the component and improve this example to add a custom min-height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants