Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPagination] Fixed wrong page count with compressed #3827

Merged
merged 3 commits into from
Jul 30, 2020
Merged

[EuiPagination] Fixed wrong page count with compressed #3827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3b7140
[EuiPagination] Fixed wrong page count with `compressed`
crux153 Jul 30, 2020
3f5478a
Updated changelog
crux153 Jul 30, 2020
d42cc82
Merge branch 'master' into 3826
thompsongl Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Fixed bug in all input fields placeholders in Safari that weren't vertically centered ([#3809](https://github.com/elastic/eui/pull/3809))
- Removed `pointer-events: none` in both `EuiButton` & `EuiButtonEmpty` to not override the `pointer-events: auto` in the button mixin `euiButtonContentDisabled` ([#3824](https://github.com/elastic/eui/pull/3824))
- Fixed bug in `EuiPagination` showing wrong page count when `compressed` prop is true. ([#3827](https://github.com/elastic/eui/pull/3827))

## [`27.3.0`](https://github.com/elastic/eui/tree/v27.3.0)

Expand Down
2 changes: 1 addition & 1 deletion src/components/pagination/pagination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ export const EuiPagination: FunctionComponent<Props> = ({
<PaginationButton pageIndex={activePage} inList={false} />
);
const lastPageButtonCompressed = (
<PaginationButton pageIndex={pageCount} inList={false} />
<PaginationButton pageIndex={pageCount - 1} inList={false} />
);
return (
<nav className={classes} {...rest}>
Expand Down