-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiPagination] Fixed wrong page count with compressed
#3827
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @crux153
Can you please also add a changelog entry under the Bugfixes section?
@thompsongl Done :) |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3827/ |
jenkins test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with the docs deployment that the correct number of pages is shown.
Will merge on green CI
Preview documentation changes for this PR: https://eui.elastic.co/pr_3827/ |
Summary
Fix for #3826.
EuiPagination was passing one based
pageCount
prop to PaginationButton'spageIndex
prop directly, which is zero based, which caused wrong page count when used withcompressed
.Before
After