Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPagination] Fixed wrong page count with compressed #3827

Merged
merged 3 commits into from
Jul 30, 2020

Conversation

crux153
Copy link
Contributor

@crux153 crux153 commented Jul 30, 2020

Summary

Fix for #3826.

if (compressed) {
    const firstPageButtonCompressed = (
      <PaginationButton pageIndex={activePage} inList={false} />
    );
    const lastPageButtonCompressed = (
      <PaginationButton pageIndex={pageCount} inList={false} />
    );
}

EuiPagination was passing one based pageCount prop to PaginationButton's pageIndex prop directly, which is zero based, which caused wrong page count when used with compressed.

Before

Screen Shot 2020-07-30 at 9 08 00 PM

After

Screen Shot 2020-07-30 at 9 34 20 PM

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @crux153

Can you please also add a changelog entry under the Bugfixes section?

@crux153
Copy link
Contributor Author

crux153 commented Jul 30, 2020

@thompsongl Done :)

@crux153 crux153 requested a review from thompsongl July 30, 2020 14:57
@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3827/

@thompsongl
Copy link
Contributor

jenkins test this

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with the docs deployment that the correct number of pages is shown.

Will merge on green CI

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3827/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants