Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed input fields placeholders not vertically centered in Safari #3809

Merged
merged 4 commits into from
Jul 29, 2020
Merged

Fixed input fields placeholders not vertically centered in Safari #3809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a273568
Fixed safari placeholder bug
elizabetdev Jul 27, 2020
c2618d6
Merge remote-tracking branch 'upstream/master' into input-fields-safa…
elizabetdev Jul 28, 2020
fb23633
Adding CL
elizabetdev Jul 28, 2020
2fcb385
Merge branch 'master' into input-fields-safari-bug
chandlerprall Jul 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## [`master`](https://github.com/elastic/eui/tree/master)

**Bug fixes**

No public interface changes since `27.3.0`.
- Fixed bug in all input fields placeholders in Safari that weren't vertically centered ([#3809](https://github.com/elastic/eui/pull/3809))

## [`27.3.0`](https://github.com/elastic/eui/tree/v27.3.0)

Expand Down
5 changes: 4 additions & 1 deletion src/global_styling/mixins/_form.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,12 @@
@mixin euiFormControlText {
@include euiFont;
font-size: $euiFontSizeS;
line-height: 1em; // fixes text alignment in IE
color: $euiTextColor;

@include internetExplorerOnly {
line-height: 1em; // fixes text alignment in IE
}

// sass-lint:disable-block mixins-before-declarations
@include euiPlaceholderPerBrowser {
color: $euiColorDarkShade;
Expand Down