Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed input fields placeholders not vertically centered in Safari #3809

Merged
merged 4 commits into from
Jul 29, 2020

Conversation

elizabetdev
Copy link
Contributor

Summary

This PR closes #3796. It fixes the inputs placeholders in Safari that weren't vertically centered.

input fields@2x

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • Checked in IE11 and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@elizabetdev elizabetdev changed the title Fixed input fields not vertically centered in Safari Fixed input fields placeholders not vertically centered in Safari Jul 28, 2020
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3809/

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Verified fix in Safari, tested for any regression/unwanted changes in Chrome/FF/Edge

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3809/

@elizabetdev elizabetdev force-pushed the input-fields-safari-bug branch from 9dce793 to fb23633 Compare July 29, 2020 17:54
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3809/

@elizabetdev elizabetdev merged commit 8f08d64 into elastic:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placeholders of input fields in Safari are not vertically centered
3 participants