Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #issue-1769 - provide a clearable option to EuiFieldSearch to sup… #2470

Closed
wants to merge 3 commits into from

Conversation

lozinska
Copy link

…port deleting the contents

Summary

Summarize your PR. If it includes design elements include a screenshot or gif.
This PR update the field search with clearable option. Unfortunately I was not able to run a test after I updated my yarn (I was able to run with my old yarn but it cause my test to fail because was not recognizing the yarn command).

Checklist

  • Checked in dark mode
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cchaos
Copy link
Contributor

cchaos commented Oct 22, 2019

Hi @lozinska , thank you for starting work on #1769 . I'm just wondering what the current state of this PR is? I'm guessing you are still working on the issue since as I run the code, it's just a new docs example but the component doesn't actually support the clearable prop yet.

@lozinska
Copy link
Author

Hi @cchaos! Yes I'm still working on this PR. Will try to fix the problem as soon as I can

@cchaos
Copy link
Contributor

cchaos commented Oct 22, 2019

No rush at all, just wanted to be sure we weren't missing something. Thanks!

@cchaos
Copy link
Contributor

cchaos commented Feb 6, 2020

@lozinska Thanks for attempting this one, but someone else happened to beat you to it. #2723

@cchaos cchaos closed this Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants