Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a "clearable" option to EuiFieldSearch to support deleting the contents #1769

Closed
wylieconlon opened this issue Mar 26, 2019 · 3 comments · Fixed by #2723
Closed

Provide a "clearable" option to EuiFieldSearch to support deleting the contents #1769

wylieconlon opened this issue Mar 26, 2019 · 3 comments · Fixed by #2723

Comments

@wylieconlon
Copy link

This is useful for filter-type searches, where the user might need to reset their filters to get back to the default state.

I imagine the presentation of this would take the form of a "clear" button and Esc keybindings, and in terms of API I would expect the default to be false. Something like:

<EuiFieldSearch value={state.filterText} onChange={this.onChange} clearable={true} />

@lozinska
Copy link

Hello there!
I would like to work on this issue.

@ryankeairns
Copy link
Contributor

Hi @lozinska , that's great!

Feel free to open a PR. There are instructions in the README with regards to contributing to the EUI project. Also, there was a similar change recently made to the date picker which would provide some direction on the potential solution - #2235

@lozinska
Copy link

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants