Reenable EsqlActionTaskIT #99686
Merged
Reenable EsqlActionTaskIT #99686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was failing every few runs. After these changes I ran it for hours in a `while` loop and it hasn't failed. Yay. This makes a small change to how we report the status of our `LuceneSourceOperator`s to line them up better with how they currently work. Closes elastic#99589 Closes elastic#99582
nik9000
added
>test
elasticsearchmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
dnhatn
approved these changes
Sep 20, 2023
| assertThat(oStatus.sliceIndex(), lessThanOrEqualTo(oStatus.totalSlices())); | ||
| assertThat(oStatus.sliceMin(), greaterThanOrEqualTo(0)); | ||
| assertThat(oStatus.sliceMax(), greaterThanOrEqualTo(oStatus.sliceMin())); | ||
| if (oStatus.sliceMin() != 0 && oStatus.sliceMin() != 0) { |
There was a problem hiding this comment.
nit: sliceMin -> sliceMax for the second clause.
nik9000
added
the
auto-merge-without-approval
|
run elasticsearch-ci/part-1 |
1 similar comment
|
run elasticsearch-ci/part-1 |
piergm
pushed a commit
to piergm/elasticsearch
that referenced
this pull request
Oct 2, 2023
This test was failing every few runs. After these changes I ran it for hours in a `while` loop and it hasn't failed. Yay. This makes a small change to how we report the status of our `LuceneSourceOperator`s to line them up better with how they currently work. Closes elastic#99589 Closes elastic#99582
jakelandis
pushed a commit
to jakelandis/elasticsearch
that referenced
this pull request
Oct 2, 2023
This test was failing every few runs. After these changes I ran it for hours in a `while` loop and it hasn't failed. Yay. This makes a small change to how we report the status of our `LuceneSourceOperator`s to line them up better with how they currently work. Closes elastic#99589 Closes elastic#99582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was failing every few runs. After these changes I ran it for hours in a
whileloop and it hasn't failed. Yay.This makes a small change to how we report the status of our
LuceneSourceOperators to line them up better with how they currently work.Closes #99589
Closes #99582