Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EsqlActionTaskIT.testCancelRead failure #99582

Closed
bpintea opened this issue Sep 14, 2023 · 4 comments · Fixed by #99686
Closed

EsqlActionTaskIT.testCancelRead failure #99582

bpintea opened this issue Sep 14, 2023 · 4 comments · Fixed by #99686
Assignees
@nik9000
Labels
:Analytics/ES|QL AKA ESQL Team:QL (Deprecated) Meta label for query languages team >test-failure Triaged test failures from CI

Comments

@bpintea
Copy link
Contributor

bpintea commented Sep 14, 2023

CI Link

https://gradle-enterprise.elastic.co/s/sa7kgcpbjsuyo

Repro line

./gradlew ':x-pack:plugin:esql:internalClusterTest' --tests "org.elasticsearch.xpack.esql.action.EsqlActionTaskIT.testCancelRead" -Dtests.seed=A10FD59C7183AD95 -Dbuild.snapshot=false -Dtests.jvm.argline="-Dbuild.snapshot=false" -Dtests.locale=ga-IE -Dtests.timezone=Europe/Stockholm -Druntime.java=20

Does it reproduce?

No

Applicable branches

main

Failure history

No response

Failure excerpt

org.elasticsearch.xpack.esql.action.EsqlActionTaskIT > testCancelRead FAILED
    java.lang.AssertionError: 
    Expected: a collection with size <2>
         but: collection size was <0>
        at __randomizedtesting.SeedInfo.seed([A10FD59C7183AD95:34226718C99014F4]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:956)
        at org.junit.Assert.assertThat(Assert.java:923)
        at org.elasticsearch.xpack.esql.action.EsqlActionTaskIT.lambda$getTasksStarting$2(EsqlActionTaskIT.java:229)
        at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:1196)
        at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:1169)
        at org.elasticsearch.xpack.esql.action.EsqlActionTaskIT.getTasksStarting(EsqlActionTaskIT.java:221)
        at org.elasticsearch.xpack.esql.action.EsqlActionTaskIT.testCancelRead(EsqlActionTaskIT.java:167)
@bpintea bpintea added >test-failure Triaged test failures from CI :Analytics/ES|QL AKA ESQL labels Sep 14, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Sep 14, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

@bpintea
Copy link
Contributor Author

bpintea commented Sep 14, 2023

Related, though different cause: #98603

@bpintea bpintea mentioned this issue Sep 14, 2023
Merged
@nik9000 nik9000 self-assigned this Sep 14, 2023
elasticsearchmachine pushed a commit that referenced this issue Sep 14, 2023
@bpintea
Mute testCancelRead() (#99585)
840d49a 
Related #99582
@ldematte
Copy link
Contributor

Possibly related: testTaskContents is also failing for me. Strangely, it fails only ~30% of the time with the same seed.
Build scan: https://gradle-enterprise.elastic.co/s/qhmqk5674pjja

nik9000 added a commit to nik9000/elasticsearch that referenced this issue Sep 19, 2023
@nik9000
Reenable EsqlActionTaskIT
89553d4 
This test was failing every few runs. After these changes I ran it for
hours in a `while` loop and it hasn't failed. Yay.

This makes a small change to how we report the status of our
`LuceneSourceOperator`s to line them up better with how they currently
work.

Closes elastic#99589
Closes elastic#99582
@nik9000 nik9000 mentioned this issue Sep 19, 2023
Merged
elasticsearchmachine pushed a commit that referenced this issue Sep 29, 2023
@nik9000
Reenable EsqlActionTaskIT (#99686)
3d870dc 
This test was failing every few runs. After these changes I ran it for
hours in a `while` loop and it hasn't failed. Yay.

This makes a small change to how we report the status of our
`LuceneSourceOperator`s to line them up better with how they currently
work.

Closes #99589 Closes #99582
piergm pushed a commit to piergm/elasticsearch that referenced this issue Oct 2, 2023
@nik9000 @piergm
Reenable EsqlActionTaskIT (elastic#99686)
bced027 
This test was failing every few runs. After these changes I ran it for
hours in a `while` loop and it hasn't failed. Yay.

This makes a small change to how we report the status of our
`LuceneSourceOperator`s to line them up better with how they currently
work.

Closes elastic#99589 Closes elastic#99582
jakelandis pushed a commit to jakelandis/elasticsearch that referenced this issue Oct 2, 2023
@nik9000 @jakelandis
Reenable EsqlActionTaskIT (elastic#99686)
611701d 
This test was failing every few runs. After these changes I ran it for
hours in a `while` loop and it hasn't failed. Yay.

This makes a small change to how we report the status of our
`LuceneSourceOperator`s to line them up better with how they currently
work.

Closes elastic#99589 Closes elastic#99582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nik9000 nik9000

Labels
:Analytics/ES|QL AKA ESQL Team:QL (Deprecated) Meta label for query languages team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reenable EsqlActionTaskIT nik9000/elasticsearch
4 participants
@nik9000 @bpintea @ldematte @elasticsearchmachine