Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require feature flag for remote cluster port test #92955

Merged
merged 7 commits into from
Jan 17, 2023
Merged

Require feature flag for remote cluster port test #92955

merged 7 commits into from
Jan 17, 2023

Conversation

n1v0lg
Copy link
Contributor

@n1v0lg n1v0lg commented Jan 16, 2023 •
edited
Loading

Fixes #92943. The test uses a feature flagged setting but does not assumeTrue on the feature flag.

@n1v0lg n1v0lg added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Network Http and internode communication implementations :Security/Security Security issues without another label v8.7.0 labels Jan 16, 2023
@n1v0lg n1v0lg requested a review from jakelandis January 16, 2023 14:53
@n1v0lg n1v0lg self-assigned this Jan 16, 2023
@elasticsearchmachine elasticsearchmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Security Meta label for security team labels Jan 16, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@n1v0lg
Copy link
Contributor Author

n1v0lg commented Jan 16, 2023

@elasticsearchmachine run elasticsearch-ci/part-3-fips

@n1v0lg n1v0lg requested a review from ywangd January 16, 2023 16:04
@n1v0lg
Copy link
Contributor Author

n1v0lg commented Jan 16, 2023

@elasticsearchmachine run elasticsearch-ci/part-3-fips

ywangd
ywangd approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n1v0lg
Copy link
Contributor Author

n1v0lg commented Jan 17, 2023

@elasticsearchmachine test this please

@n1v0lg
Copy link
Contributor Author

n1v0lg commented Jan 17, 2023

#92953 should fix the build -- will be able to merge this then.

@n1v0lg n1v0lg merged commit e7d0d05 into elastic:main Jan 17, 2023
@n1v0lg n1v0lg deleted the fix-remote-cluster-feature-flagged-test branch January 17, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelandis jakelandis jakelandis approved these changes

@ywangd ywangd ywangd approved these changes

Assignees

@n1v0lg n1v0lg

Labels
:Distributed Coordination/Network Http and internode communication implementations :Security/Security Security issues without another label Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.7.0
Projects
None yet
Milestone
No milestone
4 participants
@n1v0lg @elasticsearchmachine @jakelandis @ywangd