Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Fix failing ServiceAccountIT test #92953

Merged
merged 1 commit into from
Jan 17, 2023
Merged

[Test] Fix failing ServiceAccountIT test #92953

merged 1 commit into from
Jan 17, 2023

Conversation

slobodanadamovic
Copy link
Contributor

This commit adds a workaround for failing ServiceAccountIT test
by explicitly setting a host name to localhost instead of using default
_local_ address.

Relates to #92930

@slobodanadamovic
This commit adds a workaround for failing ServiceAccountIT test
4f1fa34 
by explicitly setting a host name to `localhost` instead of using
default `_local_` address.
@slobodanadamovic slobodanadamovic added :Security/Security Security issues without another label Team:Security Meta label for security team labels Jan 16, 2023
@slobodanadamovic slobodanadamovic self-assigned this Jan 16, 2023
@slobodanadamovic slobodanadamovic mentioned this pull request Jan 16, 2023
Closed
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@slobodanadamovic slobodanadamovic added the >test Issues or PRs that are addressing/adding tests label Jan 16, 2023
@breskeby breskeby self-requested a review January 17, 2023 14:18
breskeby
breskeby approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@breskeby breskeby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. lets wait if Mark has any comment

mark-vieira
mark-vieira approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now but I think as suggested in the original issue, the better option is to not enable FIPS on the test JVM for REST tests. As stated, it's all client code, not "code under test" so it doesn't make much sense to enable FIPS there.

@slobodanadamovic
Copy link
Contributor Author

@breskeby @mark-vieira Thank you both for the review.

@slobodanadamovic slobodanadamovic merged commit 96d3fce into elastic:main Jan 17, 2023
@slobodanadamovic slobodanadamovic deleted the sa-fix-service-account-test branch January 17, 2023 15:43
@n1v0lg n1v0lg mentioned this pull request Jan 17, 2023
Merged
@slobodanadamovic slobodanadamovic mentioned this pull request Jan 17, 2023
Merged
@slobodanadamovic
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.6

Questions ?

Please refer to the Backport tool documentation

slobodanadamovic added a commit to slobodanadamovic/elasticsearch that referenced this pull request Jan 17, 2023
@slobodanadamovic
Fix failing ServiceAccountIT test (elastic#92953)
c69244e 
This commit adds a workaround for failing `ServiceAccountIT` test
by explicitly setting a host name to `localhost` instead of using default
`_local_` address.

Relates to elastic#92930

(cherry picked from commit 96d3fce)
elasticsearchmachine pushed a commit that referenced this pull request Jan 17, 2023
@slobodanadamovic
Fix failing ServiceAccountIT test (#92953) (#93014)
051e062 
This commit adds a workaround for failing `ServiceAccountIT` test
by explicitly setting a host name to `localhost` instead of using default
`_local_` address.

Relates to #92930

(cherry picked from commit 96d3fce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breskeby breskeby breskeby approved these changes

@mark-vieira mark-vieira mark-vieira approved these changes

Assignees

@slobodanadamovic slobodanadamovic

Labels
:Security/Security Security issues without another label Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slobodanadamovic @elasticsearchmachine @breskeby @mark-vieira