docs: use valid settings in examples #92651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logstash Central Management allows key/value map for pipeline settings, but the Elasticsearch API does not perform validation of the provided settings. Here, we remove from our examples settings that have no semantic meaning to Logstash, and replace them with a meaningful key/value pair
|
Documentation preview: |
elasticsearchmachine
added
v8.7.0
needs:triage
yaauie
added
>docs
|
Pinging @elastic/es-docs (Team:Docs) |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 4, 2023
Logstash Central Management allows key/value map for pipeline settings, but the Elasticsearch API does not perform validation of the provided settings. Here, we remove from our examples settings that have no semantic meaning to Logstash, and replace them with a meaningful key/value pair
|
@grcevski can this be auto-backported to 7.17 too since the source of the doc bug goes back to 7.12? I'm not a regular contributor to Elasticsearch, so I'm not sure what the protocol is. |
|
Hi @yaauie, since we already merged this PR we can't really use the auto backport and merge option anymore. We'll need a separate PR on the 7.17 branch. You don't need another approval for backports, just force merge the PR when it comes out green from tests. I'm happy to look over the backport PR as well, just tag me. When making the backport PR, just follow what the automation did here for the 8.6 branch #92654, prefix in the title, referencing the original PR inside Thanks for fixing this. |
yaauie
added a commit
that referenced
this pull request
Jan 6, 2023
Logstash Central Management allows key/value map for pipeline settings, but the Elasticsearch API does not perform validation of the provided settings. Here, we remove from our examples settings that have no semantic meaning to Logstash, and replace them with a meaningful key/value pair
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logstash Central Management allows key/value map for
pipeline_settings, but the Elasticsearch API does not perform validation of the provided settings.Here, we remove from our examples introduced in #67788 settings that have no semantic meaning to Logstash, and replace them with a key/value pair
"queue.max_bytes": "1gb"that has been valid since at least Logstash 6.0,