Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logstash Pipeline REST api spec and documentation #67788

Merged
merged 5 commits into from
Jan 28, 2021

Conversation

jaymode
Copy link
Member

@jaymode jaymode commented Jan 20, 2021

This commit adds REST api specifications for the Logstash Pipeline APIs
and documentation of the APIs.

Closes #67360

This commit adds REST api specifications for the Logstash Pipeline APIs
and documentation of the APIs.

Closes elastic#67360
@jaymode jaymode added >docs General docs changes :Core/Infra/Core Core issues without another label v8.0.0 v7.12.0 labels Jan 20, 2021
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Core/Infra Meta label for core/infra team labels Jan 20, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@williamrandolph
Copy link
Contributor

@elasticmachine please run elasticsearch-ci/docs

Copy link
Contributor

@williamrandolph williamrandolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text and the examples look great, but it all seems to be showing up in the Watcher section of the docs, which I don't think is intended.
image

I think the fix involves moving every section up a level and making the new === sections [discrete], but perhaps there's a better way.

@jaymode
Copy link
Member Author

jaymode commented Jan 27, 2021

I put the include statement in the wrong file; it should be correct now. Good catch.

Copy link
Contributor

@williamrandolph williamrandolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jaymode jaymode merged commit 70d3040 into elastic:master Jan 28, 2021
@jaymode jaymode deleted the logstash_api_docs branch January 28, 2021 17:50
jaymode added a commit to jaymode/elasticsearch that referenced this pull request Jan 28, 2021
This commit adds REST api specifications for the Logstash Pipeline APIs
and documentation of the APIs.

Closes elastic#67360
jaymode added a commit that referenced this pull request Jan 28, 2021
This commit adds REST api specifications for the Logstash Pipeline APIs
and documentation of the APIs.

Closes #67360
Backport of #67788
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v7.12.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation needed for Logstash pipeline APIs
4 participants