Ensure cached time elapses in ClusterServiceIT #91986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than just checking `System.nanoTime()` we should verify that each thread pool's cached time has elapsed here.
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Possibly this doesn't matter in |
|
Relates #90397 |
kingherc
reviewed
Nov 29, 2022
|
|
||
| outer: do { | ||
| for (int i = 0; i < threadPools.length; i++) { | ||
| if (threadPools[i].relativeTimeInMillis() <= startTimes[i]) { |
There was a problem hiding this comment.
Is it even possible that the relativeTimeInMillis() for a threadpool could become less than when you recorded its start time above?
There was a problem hiding this comment.
It certainly shouldn't go backwards, no. But that doesn't really matter here, and IMO it'd be kind of weird to say threadPools[i].relativeTimeInMillis() == startTimes[i] in this condition here.
There was a problem hiding this comment.
OK I see, so it's sort of a safeguard.
kingherc
approved these changes
Nov 30, 2022
|
|
||
| outer: do { | ||
| for (int i = 0; i < threadPools.length; i++) { | ||
| if (threadPools[i].relativeTimeInMillis() <= startTimes[i]) { |
There was a problem hiding this comment.
OK I see, so it's sort of a safeguard.
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Dec 2, 2022
* upstream/main: (209 commits) Remove unused methods and classes from HLRC (elastic#92030) Clean up on exception while chunking XContent (elastic#92024) Add profiling plugin (elastic#91640) Remove unused methods and classes from HLRC (elastic#92012) Remove IndexerState from HLRC (elastic#92023) Ensure cached time elapses in ClusterServiceIT (elastic#91986) Chunked encoding for RestGetIndicesAction (elastic#92016) Simplify shardsWithState (elastic#91991) [DOCS] Updates ML decider docs by mentioning CPU as scaling criterion (elastic#92018) Add chunking to ClusterState.Custom impls (elastic#91963) Speedup time_series agg by caching current tsid ordinal, parent bucket ordinal and buck ordinal (elastic#91784) Drop the ingest listener call count tracking (elastic#92003) [DOCS] fixes issue number 91889 - missing [discrete] header (elastic#91976) Fix PersistentTasksClusterServiceTests (elastic#92002) [docs] Update search-settings documentation to reflect the fact that the indices.query.bool.max_clause_count setting has been deprecated (elastic#91811) Clarify writability in Netty4HttpPipeliningHandler (elastic#91982) Load stable plugins as synthetic modules (elastic#91869) Handle any exception thrown while generating source for an IngestDocument (elastic#91981) fixing Apache HttpHost url on java-rest doc (elastic#91945) Implement repair functionality for aliases colliding with indices bug (elastic#91887) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than just checking
System.nanoTime()we should verify that each thread pool's cached time has elapsed here.