Handle any exception thrown while generating source for an IngestDocument #91981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
>bug
:Data Management/Ingest Node
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @joegallo, I've created a changelog YAML for you. |
It seems misleading to use IllegalArgumentException for the general case of "something, anything, went wrong here".
masseyke
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
LGTM. As we've discussed offline I think we ought to broaden where we catch exceptions (since there are other places that would also result in the client never being notified). But this is definitely the most urgent and lowest risk place (since we have seen an exception right here in production).
The first catch block converts to an IllegalArgumentException which maps to a 400. The second block converts to a RuntimeException which maps to a 500. For bwc reasons, we don't want to change the first block, but at the same time it's not right to return a 400 for the second situation -- we don't know what happened and can't say for sure it's a problem with the request.
joegallo
deleted the
ingest-service-catch-concurrent-modification-exception
branch
joegallo
added a commit
that referenced
this pull request
Nov 29, 2022
joegallo
added a commit
that referenced
this pull request
Nov 29, 2022
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Dec 2, 2022
* upstream/main: (209 commits) Remove unused methods and classes from HLRC (elastic#92030) Clean up on exception while chunking XContent (elastic#92024) Add profiling plugin (elastic#91640) Remove unused methods and classes from HLRC (elastic#92012) Remove IndexerState from HLRC (elastic#92023) Ensure cached time elapses in ClusterServiceIT (elastic#91986) Chunked encoding for RestGetIndicesAction (elastic#92016) Simplify shardsWithState (elastic#91991) [DOCS] Updates ML decider docs by mentioning CPU as scaling criterion (elastic#92018) Add chunking to ClusterState.Custom impls (elastic#91963) Speedup time_series agg by caching current tsid ordinal, parent bucket ordinal and buck ordinal (elastic#91784) Drop the ingest listener call count tracking (elastic#92003) [DOCS] fixes issue number 91889 - missing [discrete] header (elastic#91976) Fix PersistentTasksClusterServiceTests (elastic#92002) [docs] Update search-settings documentation to reflect the fact that the indices.query.bool.max_clause_count setting has been deprecated (elastic#91811) Clarify writability in Netty4HttpPipeliningHandler (elastic#91982) Load stable plugins as synthetic modules (elastic#91869) Handle any exception thrown while generating source for an IngestDocument (elastic#91981) fixing Apache HttpHost url on java-rest doc (elastic#91945) Implement repair functionality for aliases colliding with indices bug (elastic#91887) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #91977
Regardless of what exception is thrown while generating source from an
IngestDocument, we want to catch and handle the exception -- the contract forsource(..., true)is that it can throw anIllegalArgumentExceptionif there are self references, but now that we've seen other things go wrong inside the guts of that method (and given how hard they have been to diagnose!) I think a widercatchis justified (and remains justified even in a world where #91977 has been fixed).