Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GeoGridTestCase#toXContent #85093

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Fix GeoGridTestCase#toXContent #85093

merged 1 commit into from
Mar 18, 2022

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Mar 18, 2022

This change make sure we create a valid random instance for GeoGridTestCase. The current issue is that we can generate two buckets with the same key which is invalid an makes the test fail.

Note that this change was already done in master when developing the GeoHexGridAggregation #82924

fixes #85086

@iverase iverase added >test Issues or PRs that are addressing/adding tests :Analytics/Geo Indexing, search aggregations of geo points and shapes v7.17.2 labels Mar 18, 2022
@iverase iverase requested a review from craigtaverner March 18, 2022 09:39
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Mar 18, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iverase iverase merged commit f771030 into elastic:7.17 Mar 18, 2022
@iverase iverase deleted the fixToXContent branch March 18, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v7.17.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants