Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New GeoHexGrid aggregation #82924

Merged
merged 23 commits into from
Jan 27, 2022
Merged

New GeoHexGrid aggregation #82924

merged 23 commits into from
Jan 27, 2022

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Jan 24, 2022 •
edited by jrodewig
Loading

This commit introduces a new geogrid aggregation called GeoHexGridAggregation that
is based in Uber h3 grid. It only supports geo_point fields.

Docs preview

https://elasticsearch_82924.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/search-aggregations-bucket-geohexgrid-aggregation.html

@iverase
New GeoHexGrid aggregation
50d9ce2 
This commit introduces a new geogrid aggregation called GeoHexGridAggregation that
is based in Uber h3 grid. It only supports geo_point fields.
@iverase iverase added >feature :Analytics/Geo Indexing, search aggregations of geo points and shapes v8.1.0 labels Jan 24, 2022
@iverase iverase requested review from imotov and jrodewig January 24, 2022 08:28
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 24, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@iverase iverase mentioned this pull request Jan 24, 2022
Closed
3 tasks
@iverase
Copy link
Contributor Author

iverase commented Jan 24, 2022

@elasticmachine update branch

jrodewig
jrodewig suggested changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iverase! I left some suggestions and comments. I'd like to take another look, mostly to ensure I didn't introduce any errors in my review.

docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc Outdated Show resolved Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc Outdated Show resolved Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc Outdated Show resolved Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc Outdated Show resolved Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc Outdated Show resolved Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc Outdated Show resolved Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc Outdated Show resolved Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc Outdated Show resolved Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc Show resolved Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc Outdated Show resolved Hide resolved
iverase and others added 10 commits January 24, 2022 19:46
@iverase @jrodewig
Update docs/reference/aggregations/bucket/geohexgrid-aggregation.asci…
2330f62 
…idoc

Co-authored-by: James Rodewig <[email protected]>
@iverase @jrodewig
Update docs/reference/aggregations/bucket/geohexgrid-aggregation.asci…
baa26df 
…idoc

Co-authored-by: James Rodewig <[email protected]>
@iverase @jrodewig
Update docs/reference/aggregations/bucket/geohexgrid-aggregation.asci…
cf529cf 
…idoc

Co-authored-by: James Rodewig <[email protected]>
@iverase @jrodewig
Update docs/reference/aggregations/bucket/geohexgrid-aggregation.asci…
2f83ca9 
…idoc

Co-authored-by: James Rodewig <[email protected]>
@iverase @jrodewig
Update docs/reference/aggregations/bucket/geohexgrid-aggregation.asci…
af890d2 
…idoc

Co-authored-by: James Rodewig <[email protected]>
@iverase @jrodewig
Update docs/reference/aggregations/bucket/geohexgrid-aggregation.asci…
4aad240 
…idoc

Co-authored-by: James Rodewig <[email protected]>
@iverase @jrodewig
Update docs/reference/aggregations/bucket/geohexgrid-aggregation.asci…
10356b2 
…idoc

Co-authored-by: James Rodewig <[email protected]>
@iverase @jrodewig
Update docs/reference/aggregations/bucket/geohexgrid-aggregation.asci…
0e734af 
…idoc

Co-authored-by: James Rodewig <[email protected]>
@iverase
Merge branch 'master' into GeoHexGrid
3a425db
@iverase
iter in docs
98e48cc
@elasticsearchmachine
Copy link
Collaborator

Hi @iverase, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Hi @iverase, I've updated the changelog YAML for you.

jrodewig
jrodewig approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iverase.

I pushed a few small commits containing docs edits:

If that looks good to you, these docs LGTM.

nik9000
nik9000 approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All the interesting stuff is in GeoHexCellIdSource and it works like the other similar things. @imotov should also have a look, but it seems right to me.

imotov
imotov approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iverase iverase merged commit 0873893 into elastic:master Jan 27, 2022
@iverase iverase deleted the GeoHexGrid branch January 27, 2022 06:45
@jmp601
Copy link

jmp601 commented Jan 28, 2022

Getting a 404 on the doc. Would love to take a look and prepare what we have on the horizon for GEO.

@jrodewig
Copy link
Contributor

jrodewig commented Jan 28, 2022 •
edited
Loading

Hi @jmp601, this work will be part of our upcoming 8.1.0 release. The docs for that release are currently in our master branch version:
https://www.elastic.co/guide/en/elasticsearch/reference/master/search-aggregations-bucket-geohexgrid-aggregation.html

@iverase iverase mentioned this pull request Mar 18, 2022
Merged
@craigtaverner craigtaverner mentioned this pull request Mar 24, 2023
Open
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

@imotov imotov imotov approved these changes

@nik9000 nik9000 nik9000 approved these changes

Assignees
No one assigned
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >feature Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@iverase @elasticmachine @elasticsearchmachine @jmp601 @jrodewig @nik9000 @imotov