Expect eof when daemonized #84371
Merged
Expect eof when daemonized #84371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes elastic#84204 again. When running archive packging tests with a keystore password and the -d option, there does actually need to be an `eof` expectation or else we don't capture the error when the keystore password is incorrect.
pugnascotia
added
>test
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
added
the
:Delivery/Packaging
|
@elasticmachine update branch |
mark-vieira
approved these changes
Feb 25, 2022
pugnascotia
added a commit
that referenced
this pull request
Feb 28, 2022
Closes #84204 again. When running archive packging tests with a keystore password and the -d option, there does actually need to be an `eof` expectation or else we don't capture the error when the keystore password is incorrect.
pugnascotia
added a commit
that referenced
this pull request
Feb 28, 2022
Closes #84204 again. When running archive packging tests with a keystore password and the -d option, there does actually need to be an `eof` expectation or else we don't capture the error when the keystore password is incorrect.
pugnascotia
added a commit
that referenced
this pull request
Feb 28, 2022
Closes #84204 again. When running archive packging tests with a keystore password and the -d option, there does actually need to be an `eof` expectation or else we don't capture the error when the keystore password is incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84204 again. When running archive packging tests with a keystore
password and the -d option, there does actually need to be an
eofexpectation or else we don't capture the error when the keystore
password is incorrect.