Skip to content

Commit

Permalink
Expect eof when daemonized (#84371)
Browse files Browse the repository at this point in the history
Closes #84204 again. When running archive packging tests with a keystore
password and the -d option, there does actually need to be an `eof`
expectation or else we don't capture the error when the keystore
password is incorrect.
pugnascotia committed Feb 28, 2022
1 parent 118b0cf commit 3d66dda
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
@@ -260,7 +260,7 @@ public static Shell.Result startElasticsearchWithTty(
expect "Elasticsearch keystore password:"
send "%s\\r"
""".formatted(keystorePassword);
String checkStartupScript = daemonize ? "" : """
String checkStartupScript = daemonize ? "expect eof" : """
expect {
"uncaught exception" { send_user "\\nStartup failed due to uncaught exception\\n"; exit 1 }
timeout { send_user "\\nTimed out waiting for startup to succeed\\n"; exit 1 }

0 comments on commit 3d66dda

Please sign in to comment.