Always re-run Feature migrations which have encountered errors #83918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwbrown
added
>bug
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
gwbrown
changed the title
|
Hi @gwbrown, I've created a changelog YAML for you. |
rjernst
reviewed
Feb 15, 2022
|
|
||
| @Override | ||
| public void onFailure(Exception e) { | ||
| clusterStateUpdated.set(false); |
There was a problem hiding this comment.
This should probably be captured and cause the assertBusy to fail with an assertion?
| PostFeatureUpgradeRequest migrationRequest = new PostFeatureUpgradeRequest(); | ||
| PostFeatureUpgradeResponse migrationResponse = client().execute(PostFeatureUpgradeAction.INSTANCE, migrationRequest).get(); | ||
| // Make sure we actually started the migration | ||
| final Set<String> migratingFeatures = migrationResponse.getFeatures() |
There was a problem hiding this comment.
Converting to a set isn't anymore efficient than just looking through the list. Is there som other reason we need an intermediate set to assert the feature was processed?
There was a problem hiding this comment.
This was a copy/paste from another test, you're right there's not much point to converting to a set here. I'll simplify.
… si/migration/rerun-errors
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Feb 17, 2022
…ic#83918) This PR addressed the behavior described in elastic#83917, in which Feature migrations which have encountered errors are not re-run in some cases. As of this PR, Features which have encountered errors during migration are treated the same as Features requiring migration. This PR also adds a test which artificially replicates elastic#83917.
This was referenced Feb 17, 2022
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Feb 17, 2022
…ic#83918) This PR addressed the behavior described in elastic#83917, in which Feature migrations which have encountered errors are not re-run in some cases. As of this PR, Features which have encountered errors during migration are treated the same as Features requiring migration. This PR also adds a test which artificially replicates elastic#83917.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2022
… (#84139) This PR addressed the behavior described in #83917, in which Feature migrations which have encountered errors are not re-run in some cases. As of this PR, Features which have encountered errors during migration are treated the same as Features requiring migration. This PR also adds a test which artificially replicates #83917.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 17, 2022
…#83918) (#84137) * Always re-run Feature migrations which have encountered errors (#83918) This PR addressed the behavior described in #83917, in which Feature migrations which have encountered errors are not re-run in some cases. As of this PR, Features which have encountered errors during migration are treated the same as Features requiring migration. This PR also adds a test which artificially replicates #83917. * Adjust for method signature differences in this branch
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Feb 18, 2022
* upstream/master: (167 commits) Mute FrozenSearchableSnapshotsIntegTests#testCreateAndRestorePartialSearchableSnapshot Mute LdapSessionFactoryTests#testSslTrustIsReloaded Fix spotless violation from last commit Mute GeoGridTilerTestCase#testGeoGridSetValuesBoundingBoxes_UnboundedGeoShapeCellValues Small formatting clean up (elastic#84144) Always re-run Feature migrations which have encountered errors (elastic#83918) [DOCS] Clarify `orientation` usage for WKT and GeoJSON polygons (elastic#84025) Group field caps response by index mapping hash (elastic#83494) Shrink join queries in slow log (elastic#83914) TSDB: Reject the nested object fields that are configured time_series_dimension (elastic#83920) [DOCS] Remove note about partial response from Bulk API docs (elastic#84053) Allow regular data streams to be migrated to tsdb data streams. (elastic#83843) [DOCS] Fix `ignore_unavailable` parameter definition (elastic#84071) Make Metadata extend AbstractCollection (elastic#83791) Add API specs for OpenID Connect APIs Revert "Clean up for superuser role name references (elastic#83627)" (elastic#84096) Update Lucene analysis base url (elastic#84094) Avoid null threadContext in ResultDeduplicator (elastic#84093) Use static empty store files metadata (elastic#84034) Preserve context in snapshotDeletionListeners (elastic#84089) ... # Conflicts: # x-pack/plugin/rollup/build.gradle
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Feb 22, 2022
…ic#83918) This PR addressed the behavior described in elastic#83917, in which Feature migrations which have encountered errors are not re-run in some cases. As of this PR, Features which have encountered errors during migration are treated the same as Features requiring migration. This PR also adds a test which artificially replicates elastic#83917.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 22, 2022
…83918) (#84138) * Always re-run Feature migrations which have encountered errors (#83918) This PR addressed the behavior described in #83917, in which Feature migrations which have encountered errors are not re-run in some cases. As of this PR, Features which have encountered errors during migration are treated the same as Features requiring migration. This PR also adds a test which artificially replicates #83917. * Resolve compilation failures for 8.0 branch
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this pull request
Feb 23, 2022
…ic#83918) This PR addressed the behavior described in elastic#83917, in which Feature migrations which have encountered errors are not re-run in some cases. As of this PR, Features which have encountered errors during migration are treated the same as Features requiring migration. This PR also adds a test which artificially replicates elastic#83917.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addressed the behavior described in #83917, in which Feature migrations
which have encountered errors are not re-run in some cases. As of this PR, Features
which have encountered errors during migration are treated the same as Features
requiring migration.
This PR also adds a test which artificially replicates #83917.
Fixes #83917.