-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature migration refuses to run if all features requiring upgrade have encountered errors #83917
Labels
>bug
:Core/Infra/Core
Core issues without another label
Team:Core/Infra
Meta label for core/infra team
v7.17.0
Comments
Pinging @elastic/es-core-infra (Team:Core/Infra) |
gwbrown
added a commit
that referenced
this issue
Feb 17, 2022
This PR addressed the behavior described in #83917, in which Feature migrations which have encountered errors are not re-run in some cases. As of this PR, Features which have encountered errors during migration are treated the same as Features requiring migration. This PR also adds a test which artificially replicates #83917.
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this issue
Feb 17, 2022
…ic#83918) This PR addressed the behavior described in elastic#83917, in which Feature migrations which have encountered errors are not re-run in some cases. As of this PR, Features which have encountered errors during migration are treated the same as Features requiring migration. This PR also adds a test which artificially replicates elastic#83917.
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this issue
Feb 17, 2022
…ic#83918) This PR addressed the behavior described in elastic#83917, in which Feature migrations which have encountered errors are not re-run in some cases. As of this PR, Features which have encountered errors during migration are treated the same as Features requiring migration. This PR also adds a test which artificially replicates elastic#83917.
elasticsearchmachine
pushed a commit
that referenced
this issue
Feb 17, 2022
… (#84139) This PR addressed the behavior described in #83917, in which Feature migrations which have encountered errors are not re-run in some cases. As of this PR, Features which have encountered errors during migration are treated the same as Features requiring migration. This PR also adds a test which artificially replicates #83917.
elasticsearchmachine
pushed a commit
that referenced
this issue
Feb 17, 2022
…#83918) (#84137) * Always re-run Feature migrations which have encountered errors (#83918) This PR addressed the behavior described in #83917, in which Feature migrations which have encountered errors are not re-run in some cases. As of this PR, Features which have encountered errors during migration are treated the same as Features requiring migration. This PR also adds a test which artificially replicates #83917. * Adjust for method signature differences in this branch
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this issue
Feb 22, 2022
…ic#83918) This PR addressed the behavior described in elastic#83917, in which Feature migrations which have encountered errors are not re-run in some cases. As of this PR, Features which have encountered errors during migration are treated the same as Features requiring migration. This PR also adds a test which artificially replicates elastic#83917.
elasticsearchmachine
pushed a commit
that referenced
this issue
Feb 22, 2022
…83918) (#84138) * Always re-run Feature migrations which have encountered errors (#83918) This PR addressed the behavior described in #83917, in which Feature migrations which have encountered errors are not re-run in some cases. As of this PR, Features which have encountered errors during migration are treated the same as Features requiring migration. This PR also adds a test which artificially replicates #83917. * Resolve compilation failures for 8.0 branch
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this issue
Feb 23, 2022
…ic#83918) This PR addressed the behavior described in elastic#83917, in which Feature migrations which have encountered errors are not re-run in some cases. As of this PR, Features which have encountered errors during migration are treated the same as Features requiring migration. This PR also adds a test which artificially replicates elastic#83917.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Core/Infra/Core
Core issues without another label
Team:Core/Infra
Meta label for core/infra team
v7.17.0
Elasticsearch Version
7.17.0
Installed Plugins
none
Java Version
bundled
OS Version
Doesn't matter
Problem Description
If all features which still require migration have encountered an error, trying to start migration produces no results, only a response claiming no migration is necessary, even if that's not true. This means that transient errors that occur during migration are impossible to retry.
The only known workaround for this is a full-cluster restart, which will clear the migration upgrade result metadata.
Steps to Reproduce
.tasks
always will - fortunately that is easy enough to work around by removing the index)Logs (if relevant)
The response will just say no migration is necessary:
The text was updated successfully, but these errors were encountered: