Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle shadows vars pt8 (#81147) #81250

Conversation

pugnascotia
Copy link
Contributor

Part of #19752. Fix more instances where local variable names were
shadowing field names. Also expand the possible method names that are
skipped when checking for shadowed vars, and allow shadowed vars in
builder classes.

Part of elastic#19752. Fix more instances where local variable names were
shadowing field names. Also expand the possible method names that are
skipped when checking for shadowed vars, and allow shadowed vars in
builder classes.
@pugnascotia pugnascotia added >refactoring backport :Delivery/Tooling Developer tooliing and automation auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) v7.16.1 labels Dec 2, 2021
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Dec 2, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@elasticsearchmachine elasticsearchmachine merged commit 6fc8166 into elastic:7.16 Dec 2, 2021
@pugnascotia pugnascotia deleted the checkstyle-shadows-vars-pt8-7.16 branch December 3, 2021 11:38
@danhermann danhermann added v7.16.0 and removed v7.16.1 labels Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Delivery/Tooling Developer tooliing and automation >refactoring Team:Delivery Meta label for Delivery team v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants