Checkstyle shadows vars pt8 #81147
Merged
Checkstyle shadows vars pt8 #81147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow shadowed vars in methods that return a builder. Also deviate from the JavaBeans spec regarding setter naming, since we have variables such as `xContent` with the setter `setXContent`, or `nNeighbors` with the setter `nNeighbors`.
pugnascotia
added
>refactoring
v8.0.0
:Delivery/Tooling
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
@elasticmachine update branch |
pugnascotia
added
the
auto-merge-without-approval
pugnascotia
added a commit
that referenced
this pull request
Dec 2, 2021
Part of #19752. Fix more instances where local variable names were shadowing field names. Also: * Remove unused bits and pieces from `XPackClientPlugin`. * Expand the possible method names that are skipped when checking for shadowed vars, and allow shadowed vars in builder classes.
|
Backported to |
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Dec 2, 2021
Part of elastic#19752. Fix more instances where local variable names were shadowing field names. Also expand the possible method names that are skipped when checking for shadowed vars, and allow shadowed vars in builder classes.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19752. Fix more instances where local variable names were
shadowing field names. Also:
XPackClientPlugin.checking for shadowed vars, and allow shadowed vars in
builder classes.