Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] SQL: Document async SQL search #74975

Merged
merged 3 commits into from
Jul 7, 2021
Merged

[DOCS] SQL: Document async SQL search #74975

merged 3 commits into from
Jul 7, 2021

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Jul 6, 2021 •
edited
Loading

Documents async SQL search functionality.

I plan to add formal API documentation for the async APIs with a later PR.

Relates to #73991 and #74845.

Previews

@jrodewig jrodewig marked this pull request as ready for review July 6, 2021 14:58
@jrodewig jrodewig added :Analytics/SQL SQL querying >docs General docs changes v7.14.1 v7.15.0 labels Jul 6, 2021
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team labels Jul 6, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig added v7.14.0 and removed v7.14.1 labels Jul 6, 2021
@jrodewig jrodewig marked this pull request as draft July 6, 2021 14:59
@jrodewig jrodewig marked this pull request as ready for review July 6, 2021 14:59
@jrodewig jrodewig requested a review from bpintea July 6, 2021 14:59
@jrodewig jrodewig changed the base branch from master to 7.14 July 6, 2021 17:37
@jrodewig jrodewig mentioned this pull request Jul 6, 2021
Closed
@jrodewig
Copy link
Contributor Author

jrodewig commented Jul 6, 2021

Rebased this against 7.14 to include the release highlight.

bpintea
bpintea approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the docs preview isn't based off this patch, but the changes LGTM.

docs/reference/sql/endpoints/rest.asciidoc Show resolved Hide resolved
docs/reference/sql/endpoints/rest.asciidoc Show resolved Hide resolved
@bpintea
Copy link
Contributor

bpintea commented Jul 7, 2021

I plan to add formal API documentation for the async APIs with a later PR.

Many thanks for this PR and for the API documentation, @jrodewig.
CC @stevejgordon

@jrodewig jrodewig merged commit a329217 into elastic:7.14 Jul 7, 2021
@jrodewig jrodewig deleted the docs__sql-async branch July 7, 2021 12:55
This was referenced Jul 7, 2021
Merged
Merged
elasticsearchmachine pushed a commit that referenced this pull request Jul 7, 2021
@jrodewig
[DOCS] SQL: Document async SQL search (#74975) (#75037)
0f5a0e7 
Documents async SQL search functionality.

I plan to add formal API documentation for the async APIs with a later PR.

Relates to #73991 and #74845.
# Conflicts:
#	docs/reference/release-notes/highlights.asciidoc
elasticsearchmachine pushed a commit that referenced this pull request Jul 7, 2021
@jrodewig
[DOCS] SQL: Document async SQL search (#74975) (#75038)
fa3874b 
Documents async SQL search functionality.

I plan to add formal API documentation for the async APIs with a later PR.

Relates to #73991 and #74845.
@droberts195 droberts195 mentioned this pull request Jul 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpintea bpintea bpintea approved these changes

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >docs General docs changes Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team v7.14.0 v7.15.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrodewig @elasticmachine @bpintea @jakelandis @elasticsearchmachine