Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Introduce an async querying mode for SQL #73991

Merged
merged 6 commits into from
Jun 10, 2021
Merged

SQL: Introduce an async querying mode for SQL #73991

merged 6 commits into from
Jun 10, 2021

Conversation

bpintea
Copy link
Contributor

@bpintea bpintea commented Jun 10, 2021

This adds an async query mode to SQL.
It (re)uses the same request and response async-specific EQL object
parameters.

Also similar to EQL, the running search task can have its state
monitored and canceled and its results stored and deleted, with
intermediary responses not supported (the entire result is available
once search finished).

The async implementation is extended to work with the SQL-specific
text formats (txt, csv, tsv) as well, besides xcontent.

Closes #71041.

(Feature-branch merging PR.)

bpintea added 6 commits June 3, 2021 18:02
This adds an async query mode to SQL.
It (re)uses the same request and response async-specific EQL object
parameters.

Also similar to EQL, the running search task can have its state
monitored and canceled and its results stored and deleted, with
intermediary responses not supported (the entire result is available
once search finished).

The initial query and subsequent pagination/scrolling requests will both
be started in the async mode.
This extends the async implementation to support working with the text
formats (txt, csv, tsv).

A test validating the administrator operation of a user with the
"manage" permission has also been added.
@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Jun 10, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@bpintea bpintea requested review from astefan, matriv and costin June 10, 2021 10:41
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpintea bpintea merged commit 42cc419 into master Jun 10, 2021
@bpintea bpintea deleted the feat/sql-async branch June 10, 2021 12:49
bpintea added a commit to bpintea/elasticsearch that referenced this pull request Jun 28, 2021
This adds an async query mode to SQL.
It (re)uses the same request and response async-specific EQL object
parameters.

Also similar to EQL, the running search task can have its state
monitored and canceled and its results stored and deleted, with
intermediary responses not supported (the entire result is available
once search finished).

The async implementation is extended to work with the SQL-specific
text formats (txt, csv, tsv) as well, besides xcontent.

Closes elastic#71041.

(cherry picked from commit 42cc419)
bpintea added a commit that referenced this pull request Jun 28, 2021
This adds an async query mode to SQL.
It (re)uses the same request and response async-specific EQL object
parameters.

Also similar to EQL, the running search task can have its state
monitored and canceled and its results stored and deleted, with
intermediary responses not supported (the entire result is available
once search finished).

The async implementation is extended to work with the SQL-specific
text formats (txt, csv, tsv) as well, besides xcontent.

Closes #71041.

(cherry picked from commit 42cc419)
jrodewig added a commit that referenced this pull request Jul 7, 2021
Documents async SQL search functionality.

I plan to add formal API documentation for the async APIs with a later PR.

Relates to #73991 and #74845.
elasticsearchmachine pushed a commit that referenced this pull request Jul 7, 2021
Documents async SQL search functionality.

I plan to add formal API documentation for the async APIs with a later PR.

Relates to #73991 and #74845.
# Conflicts:
#	docs/reference/release-notes/highlights.asciidoc
elasticsearchmachine pushed a commit that referenced this pull request Jul 7, 2021
Documents async SQL search functionality.

I plan to add formal API documentation for the async APIs with a later PR.

Relates to #73991 and #74845.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL: add an async querying mode
5 participants