Fix SearchReplicaSelectionIT failures #71507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes sure MockSearchService collects ARS statistics. Before, if we randomly chose to use MockSearchService then ARS information would be missing and the test would fail. Also makes the following fixes: * Removes a test workaround for the bug elastic#71022, which is now fixed. * Handle the case where nodes have same rank, to prevent random failures.
jtibshirani
added
>bug
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
jtibshirani
commented
Apr 12, 2021
| String bestNodeId = null; | ||
| double bestRank = Double.POSITIVE_INFINITY; | ||
| for (Map.Entry<String, ComputedNodeStats> entry : nodeStats.getAdaptiveSelectionStats().getComputedStats().entrySet()) { | ||
| double rank = entry.getValue().rank(1L); |
There was a problem hiding this comment.
Before we fixed #71022, we passed in 1 for the number of outstanding requests so that this rank calculation matched the one used to select shards. Now that the bug is fixed, we need to remove the workaround.
jimczi
approved these changes
Apr 15, 2021
jtibshirani
added a commit
that referenced
this pull request
Apr 15, 2021
This PR makes sure MockSearchService collects ARS statistics. Before, if we randomly chose to use MockSearchService then ARS information would be missing and the test would fail. Also makes the following fixes: * Removes a test workaround for the bug #71022, which is now fixed. * Handle the case where nodes have same rank, to prevent random failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure MockSearchService collects ARS statistics. Before, if we
randomly chose to use MockSearchService then ARS information would be missing
and the test would fail.
Also makes the following fixes:
Closes #70621.