In ARS, correct default number of outstanding requests #71022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When computing node’s ARS rank, we use the number of outstanding search requests to the node. If there are no connections to the node, we consider there to be 1 outstanding request. This isn’t accurate, the default should be 0 to indicate no outstanding requests. The ARS rank we return in node stats actually uses 0 instead of 1. This small fix lets us remove a test workaround. It also ensures the ARS ranks we return in node stats match the ranks we use to select shards during search.
jtibshirani
added
>bug
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
|
Thanks for the review. |
jtibshirani
added a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Apr 8, 2021
This PR makes sure MockSearchService collects ARS statistics. Before, if we randomly chose to use MockSearchService then ARS information would be missing and the test would fail. Also makes the following fixes: * Removes a test workaround for the bug elastic#71022, which is now fixed. * Handle the case where nodes have same rank, to prevent random failures.
jtibshirani
added a commit
that referenced
this pull request
Apr 15, 2021
This PR makes sure MockSearchService collects ARS statistics. Before, if we randomly chose to use MockSearchService then ARS information would be missing and the test would fail. Also makes the following fixes: * Removes a test workaround for the bug #71022, which is now fixed. * Handle the case where nodes have same rank, to prevent random failures.
jtibshirani
added a commit
that referenced
this pull request
Apr 15, 2021
This PR makes sure MockSearchService collects ARS statistics. Before, if we randomly chose to use MockSearchService then ARS information would be missing and the test would fail. Also makes the following fixes: * Removes a test workaround for the bug #71022, which is now fixed. * Handle the case where nodes have same rank, to prevent random failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing node’s ARS rank, we use the number of outstanding search
requests to the node. If there are no connections to the node, we consider
there to be 1 outstanding request. This isn’t accurate, the default should be 0
to indicate no outstanding requests. The ARS rank we return in node stats
actually uses 0 instead of 1.
This small fix lets us remove a test workaround. It also ensures the ARS ranks
we return in node stats match the ranks we use to select shards during search.
Follow-up to #70283.