EQL: [Tests] Simplify toml integration tests (#71064) #71095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, two files were used, `test_queries.toml` and `test_queries_unsupported.toml`. The queries where read from both files and each query in the 1st file but not in the 2nd was executed, but if it was also included in the 2nd file (unsupported) was skipped. This approach helped in first phase of developing EQL since those tests came from the EQL-endpoint implementation and we wanted to keep those files in sync. Now, we no longer need to keep this sync approach, so the unsupported queries are simply commented out in the original file: `test_queries.toml` and the `test_queries_unsupported.toml` is removed. Moreover, one more query is now enabled (previously was incorrectly still in the `test_queries_unsupported.toml` file) and a few more were added as commented out, which previously only existed in the unsupported file. Fixes: elastic#61841 (cherry picked from commit 8537b2d)
matriv
added
>test
elasticmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, two files were used,
test_queries.tomlandtest_queries_unsupported.toml. The queries where read from both filesand each query in the 1st file but not in the 2nd was executed, but if
it was also included in the 2nd file (unsupported) was skipped. This
approach helped in first phase of developing EQL since those tests came
from the EQL-endpoint implementation and we wanted to keep those files
in sync. Now, we no longer need to keep this sync approach, so the
unsupported queries are simply commented out in the original file:
test_queries.tomland thetest_queries_unsupported.tomlis removed.Moreover, one more query is now enabled (previously was
incorrectly still in the
test_queries_unsupported.tomlfile) and a fewmore were added as commented out, which previously only existed in the
unsupported file.
Fixes: #61841
(cherry picked from commit 8537b2d)