EQL: clean-up toml test execution #61841
Assignees
Labels
:Analytics/EQL
EQL querying
Team:QL (Deprecated)
Meta label for query languages team
>test
Issues or PRs that are addressing/adding tests
Comments
|
Pinging @elastic/es-ql (:Query Languages/EQL) |
matriv
added
>enhancement
>test
matriv
added a commit
to matriv/elasticsearch
that referenced
this issue
Mar 30, 2021
Previously, 2 files were used, `test_queries.toml` and `test_queries_unsupported.toml`. The queries where read from both files and each query in the 1st file but not in the 2nd was executed, but if it was also included in the 2nd file (unsupported) was skipped. This approach helped in first phase of developing EQL since those tests came from the EQL-endpoint implementation and we wanted to keep those files in sync. Now, we no longer need to keep this sync approach, so the unsupported queries are simply commented out in the original file: `test_queries.toml` and the `test_queries_unsupported.toml` is removed. Moreover, a few more queries are now enabled (previously where incorrectly still in the `test_queries_unsupported.toml` file. Fixes: elastic#61841
matriv
added a commit
that referenced
this issue
Mar 31, 2021
Previously, two files were used, `test_queries.toml` and `test_queries_unsupported.toml`. The queries where read from both files and each query in the 1st file but not in the 2nd was executed, but if it was also included in the 2nd file (unsupported) was skipped. This approach helped in first phase of developing EQL since those tests came from the EQL-endpoint implementation and we wanted to keep those files in sync. Now, we no longer need to keep this sync approach, so the unsupported queries are simply commented out in the original file: `test_queries.toml` and the `test_queries_unsupported.toml` is removed. Moreover, one more query is now enabled (previously was incorrectly still in the `test_queries_unsupported.toml` file) and a few more were added as commented out, which previously only existed in the unsupported file. Fixes: #61841
matriv
added a commit
to matriv/elasticsearch
that referenced
this issue
Mar 31, 2021
Previously, two files were used, `test_queries.toml` and `test_queries_unsupported.toml`. The queries where read from both files and each query in the 1st file but not in the 2nd was executed, but if it was also included in the 2nd file (unsupported) was skipped. This approach helped in first phase of developing EQL since those tests came from the EQL-endpoint implementation and we wanted to keep those files in sync. Now, we no longer need to keep this sync approach, so the unsupported queries are simply commented out in the original file: `test_queries.toml` and the `test_queries_unsupported.toml` is removed. Moreover, one more query is now enabled (previously was incorrectly still in the `test_queries_unsupported.toml` file) and a few more were added as commented out, which previously only existed in the unsupported file. Fixes: elastic#61841 (cherry picked from commit 8537b2d)
matriv
added a commit
that referenced
this issue
Mar 31, 2021
Previously, two files were used, `test_queries.toml` and `test_queries_unsupported.toml`. The queries where read from both files and each query in the 1st file but not in the 2nd was executed, but if it was also included in the 2nd file (unsupported) was skipped. This approach helped in first phase of developing EQL since those tests came from the EQL-endpoint implementation and we wanted to keep those files in sync. Now, we no longer need to keep this sync approach, so the unsupported queries are simply commented out in the original file: `test_queries.toml` and the `test_queries_unsupported.toml` is removed. Moreover, one more query is now enabled (previously was incorrectly still in the `test_queries_unsupported.toml` file) and a few more were added as commented out, which previously only existed in the unsupported file. Fixes: #61841 (cherry picked from commit 8537b2d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's worth looking through the test suite and verify what tests are disabled and what aren't.
The current approach of duplicating tests across different files is error-prone ; having the queries in only one place should make things easier, potentially alongside a deny list.
The text was updated successfully, but these errors were encountered: