Fix Tripped Assertion on Resync Failure during Node Shutdown #71062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can have a race here where the closed check passes and then we concurrently to a shard close try to fail the shard also. Previously this was covered by the catch below the changed code that would just ignore the already-closed exception but with elastic#69949 we're now forking to the generic pool for this logic and thus have to handle the exception in the callback as well.
original-brownbear
added
>non-issue
:Distributed Indexing/Recovery
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
original-brownbear
changed the title
original-brownbear
added
v7.12.1
:Distributed Indexing/CRUD
|
Thanks David! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Mar 31, 2021
We can have a race here where the closed check passes and then we concurrently to a shard close try to fail the shard also. Previously this was covered by the catch below the changed code that would just ignore the already-closed exception but with elastic#69949 we're now forking to the generic pool for this logic and thus have to handle the exception in the callback as well.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Mar 31, 2021
We can have a race here where the closed check passes and then we concurrently to a shard close try to fail the shard also. Previously this was covered by the catch below the changed code that would just ignore the already-closed exception but with elastic#69949 we're now forking to the generic pool for this logic and thus have to handle the exception in the callback as well.
original-brownbear
added a commit
that referenced
this pull request
Mar 31, 2021
We can have a race here where the closed check passes and then we concurrently to a shard close try to fail the shard also. Previously this was covered by the catch below the changed code that would just ignore the already-closed exception but with #69949 we're now forking to the generic pool for this logic and thus have to handle the exception in the callback as well.
original-brownbear
added a commit
that referenced
this pull request
Mar 31, 2021
We can have a race here where the closed check passes and then we concurrently to a shard close try to fail the shard also. Previously this was covered by the catch below the changed code that would just ignore the already-closed exception but with #69949 we're now forking to the generic pool for this logic and thus have to handle the exception in the callback as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can have a race here where the closed check passes and then we concurrently to
a shard close try to fail the shard also. Previously this was covered by the catch below
the changed code that would just ignore the already-closed exception but with #69949 we're
now forking to the generic pool for this logic and thus have to handle the exception in the
callback as well.
Failed in https://gradle-enterprise.elastic.co/s/5i55v7oeoekxc/tests/:server:internalClusterTest/org.elasticsearch.cluster.routing.PrimaryAllocationIT/testForceStaleReplicaToBePromotedToPrimary?expanded-stacktrace=WyIwLTEiLCIwLTEtMiIsIjAtMS0yLTMiXQ#1 and could fail elsewhere (though it's very unlikely)