-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace IndexAbstraction.Alias.getFirstAliasMetadata(...) method and related casts #66178
Merged
martijnvg
merged 4 commits into
elastic:master
from
martijnvg:remove_getFirstAliasMetadata_method
Jan 7, 2021
Merged
Replace IndexAbstraction.Alias.getFirstAliasMetadata(...) method and related casts #66178
martijnvg
merged 4 commits into
elastic:master
from
martijnvg:remove_getFirstAliasMetadata_method
Jan 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…related casts. This change is part of series of changes to clean up the usage IndexAbstraction.Alias in the codebase, so that it is no longer needed to cast to IndexAbstraction.Alias and just use the methods on the IndexAbstraction interface. This should help adding data stream aliases, so that IndexAbstraction instances of type ALIAS can also be data stream aliases. Relates to elastic#66163
martijnvg
added
>non-issue
v8.0.0
:Data Management/Data streams
Data streams and their lifecycles
v7.11.0
labels
Dec 10, 2020
elasticmachine
added
the
Team:Data Management
Meta label for data/management team
label
Dec 10, 2020
Pinging @elastic/es-core-features (Team:Core/Features) |
@elasticmachine update branch |
danhermann
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry for the delay on this one
@elasticmachine run elasticsearch-ci/2 |
@elasticmachine run elasticsearch-ci/default-distro |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Jan 7, 2021
…related casts. Backport elastic#66178 to 7.x branch. This change is part of series of changes to clean up the usage IndexAbstraction.Alias in the codebase, so that it is no longer needed to cast to IndexAbstraction.Alias and just use the methods on the IndexAbstraction interface. This should help adding data stream aliases, so that IndexAbstraction instances of type ALIAS can also be data stream aliases. Relates to elastic#66163
martijnvg
added a commit
that referenced
this pull request
Jan 7, 2021
…related casts. (#67176) Backport #66178 to 7.x branch. This change is part of series of changes to clean up the usage IndexAbstraction.Alias in the codebase, so that it is no longer needed to cast to IndexAbstraction.Alias and just use the methods on the IndexAbstraction interface. This should help adding data stream aliases, so that IndexAbstraction instances of type ALIAS can also be data stream aliases. Relates to #66163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Data Management/Data streams
Data streams and their lifecycles
>non-issue
Team:Data Management
Meta label for data/management team
v7.12.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is part of series of changes to clean up the usage IndexAbstraction.Alias in the codebase,
so that it is no longer needed to cast to IndexAbstraction.Alias and just use the methods on the IndexAbstraction
interface. This should help adding data stream aliases, so that IndexAbstraction instances of type ALIAS can
also be data stream aliases.
Relates to #66163