Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace IndexAbstraction.Alias.getFirstAliasMetadata(...) method and related casts #66178

Merged

Conversation

martijnvg
Copy link
Member

This change is part of series of changes to clean up the usage IndexAbstraction.Alias in the codebase,
so that it is no longer needed to cast to IndexAbstraction.Alias and just use the methods on the IndexAbstraction
interface. This should help adding data stream aliases, so that IndexAbstraction instances of type ALIAS can
also be data stream aliases.

Relates to #66163

…related casts.

This change is part of series of changes to clean up the usage IndexAbstraction.Alias in the codebase,
so that it is no longer needed to cast to IndexAbstraction.Alias and just use the methods on the IndexAbstraction
interface. This should help adding data stream aliases, so that IndexAbstraction instances of type ALIAS can
also be data stream aliases.

Relates to elastic#66163
@martijnvg martijnvg requested a review from danhermann December 10, 2020 15:50
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Dec 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@martijnvg martijnvg added v7.12.0 and removed v7.11.0 labels Dec 15, 2020
@martijnvg
Copy link
Member Author

@elasticmachine update branch

Copy link
Contributor

@danhermann danhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delay on this one

@martijnvg
Copy link
Member Author

@elasticmachine run elasticsearch-ci/2

@martijnvg
Copy link
Member Author

@elasticmachine run elasticsearch-ci/default-distro

@martijnvg martijnvg merged commit 77d032a into elastic:master Jan 7, 2021
martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Jan 7, 2021
…related casts.

Backport elastic#66178 to 7.x branch.

This change is part of series of changes to clean up the usage IndexAbstraction.Alias in the codebase,
so that it is no longer needed to cast to IndexAbstraction.Alias and just use the methods on the IndexAbstraction
interface. This should help adding data stream aliases, so that IndexAbstraction instances of type ALIAS can
also be data stream aliases.

Relates to elastic#66163
martijnvg added a commit that referenced this pull request Jan 7, 2021
…related casts. (#67176)

Backport #66178 to 7.x branch.

This change is part of series of changes to clean up the usage IndexAbstraction.Alias in the codebase,
so that it is no longer needed to cast to IndexAbstraction.Alias and just use the methods on the IndexAbstraction
interface. This should help adding data stream aliases, so that IndexAbstraction instances of type ALIAS can
also be data stream aliases.

Relates to #66163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Data streams Data streams and their lifecycles >non-issue Team:Data Management Meta label for data/management team v7.12.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants