Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchableSnapshotsPersistentCacheIntegTests. testCacheSurviveRestart failure #66278

Closed
benwtrent opened this issue Dec 14, 2020 · 10 comments · Fixed by #66354
Closed

SearchableSnapshotsPersistentCacheIntegTests. testCacheSurviveRestart failure #66278

benwtrent opened this issue Dec 14, 2020 · 10 comments · Fixed by #66354
Assignees
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI

Comments

@benwtrent
Copy link
Member

Build scan:
https://gradle-enterprise.elastic.co/s/xy7c3vznahvoc
Repro line:

./gradlew ':x-pack:plugin:searchable-snapshots:internalClusterTest' --tests "org.elasticsearch.xpack.searchablesnapshots.cache.SearchableSnapshotsPersistentCacheIntegTests.testCacheSurviveRestart" -Dtests.seed=9F0422EA69B04B29 -Dtests.security.manager=true -Dtests.locale=ga -Dtests.timezone=Asia/Yakutsk -Druntime.java=11

Reproduces locally?:
No, ran it with the same seed, and many different seeds but with other params being the same
Applicable branches:
master
Failure excerpt:

org.elasticsearch.xpack.searchablesnapshots.cache.SearchableSnapshotsPersistentCacheIntegTests > testCacheSurviveRestart FAILED |  
-- | --
  | java.lang.AssertionError: |  
  | Expected: <0L> |  
  | but: was <12L> |  
  | at __randomizedtesting.SeedInfo.seed([9F0422EA69B04B29:851033F89C267B6E]:0) |  
  | at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18) |  
  | at org.junit.Assert.assertThat(Assert.java:956) |  
  | at org.junit.Assert.assertThat(Assert.java:923) |  
  | at org.elasticsearch.xpack.searchablesnapshots.cache.SearchableSnapshotsPersistentCacheIntegTests.testCacheSurviveRestart(SearchableSnapshotsPersistentCacheIntegTests.java:155)
@benwtrent benwtrent added :Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI labels Dec 14, 2020
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Dec 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@tlrx tlrx self-assigned this Dec 14, 2020
tlrx added a commit to tlrx/elasticsearch that referenced this issue Dec 14, 2020
tlrx added a commit to tlrx/elasticsearch that referenced this issue Dec 14, 2020
@benwtrent
Copy link
Member Author

Another failure: https://gradle-enterprise.elastic.co/s/jpxhkvlcqq3ze/console-log?task=:x-pack:plugin:searchable-snapshots:internalClusterTest


org.elasticsearch.xpack.searchablesnapshots.cache.SearchableSnapshotsPersistentCacheIntegTests > testCacheSurviveRestart FAILED |  
-- | --
  | java.lang.AssertionError: |  
  | Expected: <0L> |  
  | but: was <10L> |  
  | at __randomizedtesting.SeedInfo.seed([98F3DDD081D6BC00:82E7CCC274408C47]:0) |  
  | at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18) |  
  | at org.junit.Assert.assertThat(Assert.java:956) |  
  | at org.junit.Assert.assertThat(Assert.java:923)

@tlrx
Copy link
Member

tlrx commented Dec 14, 2020

It will be muted in #66289

tlrx added a commit that referenced this issue Dec 14, 2020
tlrx added a commit that referenced this issue Dec 14, 2020
tlrx added a commit to tlrx/elasticsearch that referenced this issue Dec 15, 2020
@tlrx tlrx added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs and removed :Search/Search Search-related issues that do not fall into other categories labels Dec 15, 2020
@elasticmachine elasticmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. and removed Team:Search Meta label for search team labels Dec 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@tvernum tvernum reopened this Dec 18, 2020
@tlrx
Copy link
Member

tlrx commented Dec 18, 2020

Thanks @tvernum for reopening, and sorry for the noise. I opened another fix.

@costin
Copy link
Member

costin commented Dec 22, 2020

Another instance at
https://gradle-enterprise.elastic.co/s/6l445sanhzsty

@tvernum
Copy link
Contributor

tvernum commented Jan 6, 2021

This is still failing, and it looks like there's an open PR but it has stalled (due to holidays?)

Is the PR likely to pick up again, or should we mute?

@tlrx
Copy link
Member

tlrx commented Jan 15, 2021

The shard eviction mechanism has been improved in #67160, which should in turn fix this issue.

@tlrx tlrx closed this as completed Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI
Projects
None yet
6 participants