Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate translog retention settings #51588

Merged
merged 2 commits into from
Jan 29, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jan 29, 2020

This change deprecates the translog retention settings as they are effectively ignored since 7.4.

Relates #50775
Relates #45473

@dnhatn dnhatn added >deprecation :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 v7.7.0 labels Jan 29, 2020
@dnhatn dnhatn requested a review from ywelsch January 29, 2020 03:54
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Engine)

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Jan 29, 2020

Thanks Yannick.

@dnhatn dnhatn merged commit 2aa650c into elastic:master Jan 29, 2020
@dnhatn dnhatn deleted the deprecate-translog-settings branch January 29, 2020 15:19
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Jan 29, 2020
This change deprecates the translog retention settings as they are
effectively ignored since 7.4.

Relates elastic#50775
Relates elastic#45473
dnhatn added a commit that referenced this pull request Jan 30, 2020
This change deprecates the translog retention settings as they are
effectively ignored since 7.4.

Relates #50775
Relates #45473
dnhatn added a commit that referenced this pull request Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>deprecation :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants