-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate translog retention settings #51588
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>deprecation
:Distributed Indexing/Engine
Anything around managing Lucene and the Translog in an open shard.
v8.0.0
v7.7.0
labels
Jan 29, 2020
Pinging @elastic/es-distributed (:Distributed/Engine) |
ywelsch
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rest-api-spec/src/main/resources/rest-api-spec/test/indices.stats/20_translog.yml
Outdated
Show resolved
Hide resolved
Thanks Yannick. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jan 29, 2020
This change deprecates the translog retention settings as they are effectively ignored since 7.4. Relates elastic#50775 Relates elastic#45473
dnhatn
added a commit
that referenced
this pull request
Jan 30, 2020
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>deprecation
:Distributed Indexing/Engine
Anything around managing Lucene and the Translog in an open shard.
v7.7.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change deprecates the translog retention settings as they are effectively ignored since 7.4.
Relates #50775
Relates #45473