-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make soft-deletes mandatory #50775
Labels
:Distributed Indexing/Engine
Anything around managing Lucene and the Translog in an open shard.
Meta
Comments
dnhatn
added
Meta
:Distributed Indexing/Engine
Anything around managing Lucene and the Translog in an open shard.
labels
Jan 9, 2020
Pinging @elastic/es-distributed (:Distributed/Engine) |
This was referenced Jan 16, 2020
dnhatn
added a commit
that referenced
this issue
Jan 20, 2020
Currently, we do not exclude soft-deleted documents when opening index reader in the FrozenEngine. Relates #50775
dnhatn
added a commit
that referenced
this issue
Jan 20, 2020
We no longer need to explicitly enable soft-deletes in CCR tests. Relates #50775
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this issue
Jan 20, 2020
Currently, we do not exclude soft-deleted documents when opening index reader in the FrozenEngine. Relates elastic#50775
dnhatn
added a commit
that referenced
this issue
Jan 20, 2020
We can use Lucene index exclusively in peer recoveries and primary-replica resync in 8.0. Relates #50775
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this issue
Jan 23, 2020
Currently, we do not exclude soft-deleted documents when opening index reader in the FrozenEngine. Relates elastic#50775
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this issue
Jan 23, 2020
We no longer need to explicitly enable soft-deletes in CCR tests. Relates elastic#50775
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this issue
Jan 23, 2020
Currently, we do not exclude soft-deleted documents when opening index reader in the FrozenEngine. Relates elastic#50775
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this issue
Jan 23, 2020
We no longer need to explicitly enable soft-deletes in CCR tests. Relates elastic#50775
dnhatn
added a commit
that referenced
this issue
Jan 23, 2020
dnhatn
added a commit
that referenced
this issue
Jan 23, 2020
dnhatn
added a commit
that referenced
this issue
Jan 24, 2020
We no longer need to retain the extra translog for peer recovery as we have switched using Lucene index exclusively in 8.0. This change removes the translog retention policy. Relates #50775
dnhatn
added a commit
that referenced
this issue
Jan 29, 2020
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this issue
Jan 29, 2020
This change deprecates the translog retention settings as they are effectively ignored since 7.4. Relates elastic#50775 Relates elastic#45473
dnhatn
added a commit
that referenced
this issue
Jan 30, 2020
dnhatn
added a commit
that referenced
this issue
Jan 31, 2020
The translog retention settings index.translog.retention.size and index.translog.retention.age were effectively ignored in 7.4, deprecated in 7.7, and now removed in 8.0 in favor of soft-deletes. Closes #50775
This was referenced Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Indexing/Engine
Anything around managing Lucene and the Translog in an open shard.
Meta
Peer recoveries become faster and use less storage (i.e., no more extra translog) with soft-deletes. Soft-deletes has been enabled by default since 7.0. We should make it mandatory in 8.0, so we can simplify the logic in the engine, translog, recoveries, and other components. This meta issue tracks works to be done on this story.
More tests for corner cases
Cleanup:
Clean up soft-deletes setting in tests(let's do it in 9.0 so we can back port to 8.0)The text was updated successfully, but these errors were encountered: