Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logging when failing watch history entry fails. #50931

Merged
merged 3 commits into from
Jan 16, 2020
Merged

Add more logging when failing watch history entry fails. #50931

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be61ce5
Add more logging when failing watch history entry fails.
martijnvg Jan 13, 2020
368f85a
Merge remote-tracking branch 'es/master' into SmokeTestWatcherWithSec…
martijnvg Jan 16, 2020
b2a52e1
iter
martijnvg Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 48 additions & 29 deletions ...th-security/src/test/java/org/elasticsearch/smoketest/SmokeTestWatcherWithSecurityIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,39 +305,58 @@ private ObjectPath getWatchHistoryEntry(String watchId) throws Exception {

private ObjectPath getWatchHistoryEntry(String watchId, String state) throws Exception {
final AtomicReference<ObjectPath> objectPathReference = new AtomicReference<>();
assertBusy(() -> {
client().performRequest(new Request("POST", "/.watcher-history-*/_refresh"));

try (XContentBuilder builder = jsonBuilder()) {
builder.startObject();
builder.startObject("query").startObject("bool").startArray("must");
builder.startObject().startObject("term").startObject("watch_id").field("value", watchId).endObject().endObject()
try {
assertBusy(() -> {
client().performRequest(new Request("POST", "/.watcher-history-*/_refresh"));

try (XContentBuilder builder = jsonBuilder()) {
builder.startObject();
builder.startObject("query").startObject("bool").startArray("must");
builder.startObject().startObject("term").startObject("watch_id").field("value", watchId).endObject().endObject()
.endObject();
if (Strings.isNullOrEmpty(state) == false) {
builder.startObject().startObject("term").startObject("state").field("value", state).endObject().endObject()
if (Strings.isNullOrEmpty(state) == false) {
builder.startObject().startObject("term").startObject("state").field("value", state).endObject().endObject()
.endObject();
}
builder.endArray().endObject().endObject();
builder.startArray("sort").startObject().startObject("trigger_event.triggered_time").field("order", "desc").endObject()
}
builder.endArray().endObject().endObject();
builder.startArray("sort").startObject().startObject("trigger_event.triggered_time").field("order", "desc").endObject()
.endObject().endArray();
builder.endObject();

Request searchRequest = new Request("POST", "/.watcher-history-*/_search");
searchRequest.addParameter(TOTAL_HITS_AS_INT_PARAM, "true");
searchRequest.setJsonEntity(Strings.toString(builder));
Response response = client().performRequest(searchRequest);
ObjectPath objectPath = ObjectPath.createFromResponse(response);
int totalHits = objectPath.evaluate("hits.total");
assertThat(totalHits, is(greaterThanOrEqualTo(1)));
String watchid = objectPath.evaluate("hits.hits.0._source.watch_id");
assertThat(watchid, is(watchId));
objectPathReference.set(objectPath);
} catch (ResponseException e) {
final String err = "Failed to perform search of watcher history";
logger.info(err, e);
fail(err);
builder.endObject();

Request searchRequest = new Request("POST", "/.watcher-history-*/_search");
searchRequest.addParameter(TOTAL_HITS_AS_INT_PARAM, "true");
searchRequest.setJsonEntity(Strings.toString(builder));
Response response = client().performRequest(searchRequest);
ObjectPath objectPath = ObjectPath.createFromResponse(response);
int totalHits = objectPath.evaluate("hits.total");
assertThat(totalHits, is(greaterThanOrEqualTo(1)));
String watchid = objectPath.evaluate("hits.hits.0._source.watch_id");
assertThat(watchid, is(watchId));
objectPathReference.set(objectPath);
} catch (ResponseException e) {
final String err = "Failed to perform search of watcher history";
logger.info(err, e);
fail(err);
}
});
} catch (AssertionError ae) {
{
Request request = new Request("GET", "/_watcher/stats");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may want add metric=_all to include current and queued watches.

/_watcher/stats?metric=_all

Response response = client().performRequest(request);
logger.info("watcher_stats: {}", EntityUtils.toString(response.getEntity()));
}
});
{
Request request = new Request("GET", "/_cluster/state");
Response response = client().performRequest(request);
logger.info("cluster_state: {}", EntityUtils.toString(response.getEntity()));
}
{
Request request = new Request("GET", "/.watcher-history-*/_search");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this fails and is stuck for during the assertBusy, may result in alot of .watcher_history... should we increase the default size ?

Response response = client().performRequest(request);
logger.info("watcher_history_snippets: {}", EntityUtils.toString(response.getEntity()));
}
throw ae;
}
return objectPathReference.get();
}
}