Add more logging when failing watch history entry fails. #50931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
>test
|
Pinging @elastic/es-core-features (:Core/Features/Watcher) |
|
@elasticmachine run elasticsearch-ci/2 |
This was referenced Jan 14, 2020
Closed
jakelandis
reviewed
Jan 15, 2020
| }); | ||
| } catch (AssertionError ae) { | ||
| { | ||
| Request request = new Request("GET", "/_watcher/stats"); |
There was a problem hiding this comment.
you may want add metric=_all to include current and queued watches.
/_watcher/stats?metric=_all
jakelandis
reviewed
Jan 15, 2020
| logger.info("cluster_state: {}", EntityUtils.toString(response.getEntity())); | ||
| } | ||
| { | ||
| Request request = new Request("GET", "/.watcher-history-*/_search"); |
There was a problem hiding this comment.
When this fails and is stuck for during the assertBusy, may result in alot of .watcher_history... should we increase the default size ?
|
LGTM - a couple minor suggestions. |
…urityIT_more_logging
|
@elasticmachine run elasticsearch-ci/2 |
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
martijnvg
added a commit
that referenced
this pull request
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #30777