Allow simple connection strategy to be configured #49066
Conversation
Tim-Brooks
added
>non-issue
WIP
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed (:Distributed/Network) |
server/src/main/java/org/elasticsearch/common/settings/ClusterSettings.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/transport/RemoteConnectionStrategy.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/transport/RemoteConnectionStrategy.java
Outdated
Show resolved
Hide resolved
| public static final Setting.AffixSetting<List<String>> REMOTE_CLUSTER_SEEDS = Setting.affixKeySetting( | ||
| "cluster.remote.", | ||
| "sniff.seeds", | ||
| key -> Setting.listSetting(key, |
There was a problem hiding this comment.
There is a listSetting overload that allows providing a fallback setting. Why not use that?
There was a problem hiding this comment.
I don't follow your comment here. The listSetting there is taking a fallback setting? I followed the example of what we did for the search.remote -> cluster.remote transition here.
There was a problem hiding this comment.
It's the lines below this comment that confuse me, in particular that regexp magic. I wonder why that is necessary.
There was a problem hiding this comment.
The regex is necessary because "key" is not the namespace. It is the settings key. So in the non-"na" case this will be "cluster.remote.cluster_name.sniff.seeds". The regex produces the proper fallback key "cluster.remote.cluster_name.seeds". The example for this is in the ScopedSettingsTests#testDependentSettingsWithFallback test.
There was a problem hiding this comment.
ok, thanks for the explanation.
server/src/test/java/org/elasticsearch/transport/RemoteClusterConnectionTests.java
Outdated
Show resolved
Hide resolved
| public static final Setting.AffixSetting<List<String>> REMOTE_CLUSTER_SEEDS = Setting.affixKeySetting( | ||
| "cluster.remote.", | ||
| "sniff.seeds", | ||
| key -> Setting.listSetting(key, |
There was a problem hiding this comment.
It's the lines below this comment that confuse me, in particular that regexp magic. I wonder why that is necessary.
server/src/test/java/org/elasticsearch/transport/RemoteClusterConnectionTests.java
Outdated
Show resolved
Hide resolved
Currently the simple connection strategy only exists in the code. It cannot be configured. This commit moves in the direction of allowing it to be configured. It introduces settings for the addresses and socket count. Additionally it introduces new settings for the sniff strategy so that the more generic number of connections and seed node settings can be deprecated. The simple settings are not yet registered as the registration is dependent on follow-up work to validate the settings.
This commit back ports three commits related to enabling the simple connection strategy. Allow simple connection strategy to be configured (#49066) Currently the simple connection strategy only exists in the code. It cannot be configured. This commit moves in the direction of allowing it to be configured. It introduces settings for the addresses and socket count. Additionally it introduces new settings for the sniff strategy so that the more generic number of connections and seed node settings can be deprecated. The simple settings are not yet registered as the registration is dependent on follow-up work to validate the settings. Ensure at least 1 seed configured in remote test (#49389) This fixes #49384. Currently when we select a random subset of seed nodes from a list, it is possible for 0 seeds to be selected. This test depends on at least 1 seed being selected. Add the simple strategy to cluster settings (#49414) This is related to #49067. This commit adds the simple connection strategy settings and strategy mode setting to the cluster settings registry. With these changes, the simple connection mode can be used. Additionally, it adds validation to ensure that settings cannot be misconfigured.
Currently the simple connection strategy only exists in the code. It
cannot be configured. This commit moves in the direction of allowing it
to be configured. It introduces settings for the addresses and socket
count. Additionally it introduces new settings for the sniff strategy
so that the more generic number of connections and seed node settings
can be deprecated.
The simple settings are not yet registered as the registration is
dependent on follow-up work to validate the settings.