Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoteClusterConnectionTests#testConnectedNodesConcurrentAccess fails #49384

Closed
jimczi opened this issue Nov 20, 2019 · 1 comment · Fixed by #49389
Closed

RemoteClusterConnectionTests#testConnectedNodesConcurrentAccess fails #49384

jimczi opened this issue Nov 20, 2019 · 1 comment · Fixed by #49389
Assignees
Labels
:Distributed Coordination/Network Http and internode communication implementations >test-failure Triaged test failures from CI

Comments

@jimczi
Copy link
Contributor

jimczi commented Nov 20, 2019

The test fails on CI and locally with the following in master:

./gradlew ':server:test' --tests "org.elasticsearch.transport.RemoteClusterConnectionTests.testConnectedNodesConcurrentAccess" -Dtests.seed=5DC7FA5D13FE3F86 -Dtests.security.manager=true -Dtests.locale=hu-HU -Dtests.timezone=Africa/Nouakchott -Dcompiler.java=12
@jimczi jimczi added :Distributed Coordination/Network Http and internode communication implementations >test-failure Triaged test failures from CI labels Nov 20, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Network)

Tim-Brooks added a commit to Tim-Brooks/elasticsearch that referenced this issue Nov 20, 2019
This fixes elastic#49384. Currently when we select a random subset of seed
nodes from a list, it is possible for 0 seeds to be selected. This test
depends on at least 1 seed being selected.
Tim-Brooks added a commit that referenced this issue Nov 20, 2019
This fixes #49384. Currently when we select a random subset of seed
nodes from a list, it is possible for 0 seeds to be selected. This test
depends on at least 1 seed being selected.
Tim-Brooks added a commit to Tim-Brooks/elasticsearch that referenced this issue Nov 25, 2019
This fixes elastic#49384. Currently when we select a random subset of seed
nodes from a list, it is possible for 0 seeds to be selected. This test
depends on at least 1 seed being selected.
Tim-Brooks added a commit that referenced this issue Nov 25, 2019
This commit back ports three commits related to enabling the simple
connection strategy.

Allow simple connection strategy to be configured (#49066)

Currently the simple connection strategy only exists in the code. It
cannot be configured. This commit moves in the direction of allowing it
to be configured. It introduces settings for the addresses and socket
count. Additionally it introduces new settings for the sniff strategy
so that the more generic number of connections and seed node settings
can be deprecated.

The simple settings are not yet registered as the registration is
dependent on follow-up work to validate the settings.

Ensure at least 1 seed configured in remote test (#49389)

This fixes #49384. Currently when we select a random subset of seed
nodes from a list, it is possible for 0 seeds to be selected. This test
depends on at least 1 seed being selected.

Add the simple strategy to cluster settings (#49414)

This is related to #49067. This commit adds the simple connection
strategy settings and strategy mode setting to the cluster settings
registry. With these changes, the simple connection mode can be used.
Additionally, it adds validation to ensure that settings cannot be
misconfigured.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Network Http and internode communication implementations >test-failure Triaged test failures from CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants