Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resiliency to auto-formatting in libs, modules #48619

Merged

Conversation

pugnascotia
Copy link
Contributor

Backport of #48448. Make a number of changes so that code in the libs and
modules directories are more resilient to automatic formatting. This covers:

  • Remove string concatenation where JSON fits on a single line
  • Move some comments around to they aren't auto-formatted to a strange
    place

Make a number of changes so that code in the `libs` and `modules`
directories are more resilient to automatic formatting. This covers:

* Remove string concatenation where JSON fits on a single line
* Move some comments around to they aren't auto-formatted to a strange
  place
@pugnascotia pugnascotia added :Core/Infra/Core Core issues without another label backport v7.6.0 labels Oct 29, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Core)

@pugnascotia pugnascotia merged commit 3c77c50 into elastic:7.x Oct 29, 2019
@pugnascotia pugnascotia deleted the formatting-fixes-libs-modules-7-x branch October 29, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Core/Infra/Core Core issues without another label v7.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants