Improve resiliency to auto-formatting in libs, modules #48448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make a number of changes so that code in the `libs` and `modules` directories are more resilient to automatic formatting. This covers: * Format cipher lists vertically, instead of horizontally * Remove string concatenation where JSON fits on a single line * Move some comments around to they aren't auto-formatted to a strange place
pugnascotia
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Oct 29, 2019
Make a number of changes so that code in the `libs` and `modules` directories are more resilient to automatic formatting. This covers: * Remove string concatenation where JSON fits on a single line * Move some comments around to they aren't auto-formatted to a strange place
pugnascotia
added a commit
that referenced
this pull request
Oct 29, 2019
Backport of #48448. Make a number of changes so that code in the libs and modules directories are more resilient to automatic formatting. This covers: * Remove string concatenation where JSON fits on a single line * Move some comments around to they aren't auto-formatted to a strange place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a number of changes so that code in the
libsandmodulesdirectories are more resilient to automatic formatting. This covers:place